* inferiors.c (remove_process): Fix memory leak, free process.

	* linux-low.c (linux_remove_process): New function.
	(linux_kill): Call it instead of remove_process.
	(linux_detach, linux_wait_1): Ditto.

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 8d4e2f288e3afc711b0d0192122b6099b1a303c0..a731bfff2e503fb0a83f1356f5b83f079ff88977 100644 (file)
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,10 @@
+2009-04-30  Doug Evans  <dje@google.com>
+
+       * inferiors.c (remove_process): Fix memory leak, free process.
+       * linux-low.c (linux_remove_process): New function.
+       (linux_kill): Call it instead of remove_process.
+       (linux_detach, linux_wait_1): Ditto.
+
 2009-04-19  Danny Backx  <dannybackx@users.sourceforge.net>
 
        * configure.srv: Add x86 Windows CE target.

diff --git a/gdb/gdbserver/inferiors.c b/gdb/gdbserver/inferiors.c
index f96438ef5368726e02d13157d3fb1826c45b9747..8d44d0160a2e717bcb38c5d60f0559c665ab70ab 100644 (file)
--- a/gdb/gdbserver/inferiors.c
+++ b/gdb/gdbserver/inferiors.c
@@ -427,12 +427,17 @@ add_process (int pid, int attached)
   return process;
 }
 
+/* Remove a process from the common process list and free the memory
+   allocated for it.
+   The caller is responsible for freeing private data first.  */
+
 void
 remove_process (struct process_info *process)
 {
   clear_symbol_cache (&process->symbol_cache);
   free_all_breakpoints (process);
   remove_inferior (&all_processes, &process->head);
+  free (process);
 }
 
 struct process_info *

diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index cb6b1b47df011a49875d792284aad314396b142f..a6bad392c09ac75682fc8b3089047dc14e2ac53d 100644 (file)
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -182,6 +182,16 @@ linux_add_process (int pid, int attached)
   return proc;
 }
 
+/* Remove a process from the common process list,
+   also freeing all private data.  */
+
+static void
+linux_remove_process (struct process_info *process)
+{
+  free (process->private);
+  remove_process (process);
+}
+
 /* Handle a GNU/Linux extended wait response.  If we see a clone
    event, we need to add the new LWP to our list (and not report the
    trap to higher layers).  */
@@ -565,7 +575,7 @@ linux_kill (int pid)
     } while (lwpid > 0 && WIFSTOPPED (wstat));
 
   delete_lwp (lwp);
-  remove_process (process);
+  linux_remove_process (process);
   return 0;
 }
 
@@ -654,7 +664,7 @@ linux_detach (int pid)
 
   delete_all_breakpoints ();
   find_inferior (&all_threads, linux_detach_one_lwp, &pid);
-  remove_process (process);
+  linux_remove_process (process);
   return 0;
 }
 
@@ -1273,7 +1283,7 @@ retry:
          struct process_info *process = find_process_pid (pid);
 
          delete_lwp (lwp);
-         remove_process (process);
+         linux_remove_process (process);
 
          current_inferior = NULL;