gdb/testsuite: use clean_restart in gdb.server/ext-run.exp

I think the sequence of commands here could be replaced with
clean_restart.  The test starts with GDB not started, so it should not
be started when we reach gdb_skip_xml_test.

gdb/testsuite/ChangeLog:

	* gdb.server/ext-run.exp: Use clean_restart.

Change-Id: I8c033bad6c52f3d58d6aa377b8355fc633c7aede

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3200c349fa2100c6f3f636f86bd54de73c1af3f5..053e12ebe4f35bd41e8612730453617652838c2e 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2021-01-04  Simon Marchi  <simon.marchi@efficios.com>
+
+       * gdb.server/ext-run.exp: Use clean_restart.
+
 2021-01-04  Simon Marchi  <simon.marchi@efficios.com>
 
        * gdb.server/stop-reply-no-thread.exp: Use build_executable

diff --git a/gdb/testsuite/gdb.server/ext-run.exp b/gdb/testsuite/gdb.server/ext-run.exp
index 7d657595463aeb1746fa6abca362ceb9416ea2a0..92aef1417843ee04d909174ccfd3110190db729d 100644 (file)
--- a/gdb/testsuite/gdb.server/ext-run.exp
+++ b/gdb/testsuite/gdb.server/ext-run.exp
@@ -29,14 +29,10 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
     return -1
 }
 
-# Start with a fresh gdb, gdb_skip_xml_test must be called while gdb
-# is not running.
-
-gdb_exit
+# gdb_skip_xml_test must be called while gdb is not running.
 set do_xml_test [expr ![gdb_skip_xml_test]]
-gdb_start
-gdb_load $binfile
-gdb_reinitialize_dir $srcdir/$subdir
+
+clean_restart $binfile
 
 # Make sure we're disconnected, in case we're testing with an
 # extended-remote board, therefore already connected.