* elf32-spu.c (spu_elf_size_stubs): Always use an overlay stub
authorAlan Modra <amodra@gmail.com>
Sat, 17 Mar 2007 02:56:37 +0000 (02:56 +0000)
committerAlan Modra <amodra@gmail.com>
Sat, 17 Mar 2007 02:56:37 +0000 (02:56 +0000)
on setjmp calls.

bfd/ChangeLog
bfd/elf32-spu.c

index 7f319a79ca4d647c52303d95a0ab3f85e2d4d0e1..3db69191cd411cfad2cae45bd5d0e3fc9bef723b 100644 (file)
@@ -1,3 +1,8 @@
+2007-03-17  Alan Modra  <amodra@bigpond.net.au>
+
+       * elf32-spu.c (spu_elf_size_stubs): Always use an overlay stub
+       on setjmp calls.
+
 2007-03-15  H.J. Lu  <hongjiu.lu@intel.com>
 
        * doc/Makefile.in: Regenerated.
index 8d130b86ff26936949254d4fbeecbf9dff8565e6..0326e84c962c841c995002e5de5d713d340071e1 100644 (file)
@@ -801,6 +801,7 @@ spu_elf_size_stubs (bfd *output_bfd,
              struct spu_stub_hash_entry *sh;
              unsigned int sym_type;
              enum _insn_type { non_branch, branch, call } insn_type;
+             bfd_boolean is_setjmp;
 
              r_type = ELF32_R_TYPE (irela->r_info);
              r_indx = ELF32_R_SYM (irela->r_info);
@@ -877,15 +878,26 @@ spu_elf_size_stubs (bfd *output_bfd,
                    continue;
                }
 
+             /* setjmp always goes via an overlay stub, because
+                then the return and hence the longjmp goes via
+                __ovly_return.  That magically makes setjmp/longjmp
+                between overlays work.  */
+             is_setjmp = (h != NULL
+                          && strncmp (h->root.root.string, "setjmp", 6) == 0
+                          && (h->root.root.string[6] == '\0'
+                              || h->root.root.string[6] == '@'));
+
              /* Usually, non-overlay sections don't need stubs.  */
              if (!spu_elf_section_data (sym_sec->output_section)->ovl_index
-                 && !non_overlay_stubs)
+                 && !non_overlay_stubs
+                 && !is_setjmp)
                continue;
 
              /* We need a reference from some other section before
                 we consider that a symbol might need an overlay stub.  */
              if (spu_elf_section_data (sym_sec->output_section)->ovl_index
-                 == spu_elf_section_data (section->output_section)->ovl_index)
+                 == spu_elf_section_data (section->output_section)->ovl_index
+                 && !is_setjmp)
                {
                  /* Or we need this to *not* be a branch.  ie. We are
                     possibly taking the address of a function and