Don't call set_current_source_symtab_and_line from TUI
authorTom Tromey <tom@tromey.com>
Wed, 13 Nov 2019 22:54:47 +0000 (15:54 -0700)
committerTom Tromey <tom@tromey.com>
Fri, 20 Dec 2019 16:15:56 +0000 (09:15 -0700)
update_source_window_as_is calls set_current_source_symtab_and_line,
but I don't think there is any reason it should be doing this.  This
patch removes the call.

gdb/ChangeLog
2019-12-20  Tom Tromey  <tom@tromey.com>

* tui/tui-winsource.c
(tui_source_window_base::update_source_window_as_is): Don't call
set_current_source_symtab_and_line.

Change-Id: I1152fc7c78150974bd3d555b8568a6f88b65dbe6

gdb/ChangeLog
gdb/tui/tui-winsource.c

index 887e04e57dd488cccf0e8980731ce16787ed0539..2bdfba75fbeb8af60b9648b84068fb7022aa4e75 100644 (file)
@@ -1,3 +1,9 @@
+2019-12-20  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c
+       (tui_source_window_base::update_source_window_as_is): Don't call
+       set_current_source_symtab_and_line.
+
 2019-12-20  Tom Tromey  <tom@tromey.com>
 
        * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
index 3305c8cd969981dd0ecedb6ae934bf368abd0434..1ac650b69879308d83642518c03f11c5c617c7c3 100644 (file)
@@ -190,13 +190,6 @@ tui_source_window_base::update_source_window_as_is
       update_breakpoint_info (nullptr, false);
       show_source_content ();
       update_exec_info ();
-      if (type == SRC_WIN)
-       {
-         symtab_and_line new_sal = sal;
-
-         new_sal.line = sal.line + (content.size () - 2);
-         set_current_source_symtab_and_line (new_sal);
-       }
     }
 }