egl/x11: use the no-op dri2_fallback_copy_buffers for swrast
authorEmil Velikov <emil.velikov@collabora.com>
Wed, 27 Jun 2018 17:17:37 +0000 (18:17 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Tue, 7 Aug 2018 16:59:09 +0000 (17:59 +0100)
Currently dri2_copy_buffers is used for swrast, which depends on the
DRI2_FLUSH extension. Since that's not a thing on software based
drivers we crash out.

Do the slightly more graceful, thing of returning EGL_FALSE.

Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
src/egl/drivers/dri2/platform_x11.c

index cfa5c4aa2bf63d652de39dad63b3264b0dbea196..cc912d2b71f58558f4543feb2c4bb71bfd6cf33c 100644 (file)
@@ -1189,7 +1189,8 @@ static const struct dri2_egl_display_vtbl dri2_x11_swrast_display_vtbl = {
    .set_damage_region = dri2_fallback_set_damage_region,
    .swap_buffers_region = dri2_fallback_swap_buffers_region,
    .post_sub_buffer = dri2_fallback_post_sub_buffer,
-   .copy_buffers = dri2_x11_copy_buffers,
+   /* XXX: should really implement this since X11 has pixmaps */
+   .copy_buffers = dri2_fallback_copy_buffers,
    .query_buffer_age = dri2_fallback_query_buffer_age,
    .query_surface = dri2_query_surface,
    .create_wayland_buffer_from_image = dri2_fallback_create_wayland_buffer_from_image,