Prevent flickering when redrawing the TUI source window

tui_win_info::refresh_window simply calls wrefresh, which internally
does a doupdate.
This redraws the source background window without the source pad.
Then prefresh of the source pad draws the actual source code on top,
which flickers.

By changing this to wnoutrefresh, the actual drawing on the screen is
only done once in the following prefresh, without flickering.

gdb/ChangeLog:

2021-01-05  Hannes Domani  <ssbssa@yahoo.de>

	* tui/tui-winsource.c (tui_source_window_base::refresh_window):
	Call wnoutrefresh instead of tui_win_info::refresh_window.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 20ceaa26ae7195dacfeba7ac12822ed94d43c9bc..4a7d801edb6a58f1dac485f6b3ace09716a7ade1 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2021-01-05  Hannes Domani  <ssbssa@yahoo.de>
+
+       * tui/tui-winsource.c (tui_source_window_base::refresh_window):
+       Call wnoutrefresh instead of tui_win_info::refresh_window.
+
 2021-01-05  Hannes Domani  <ssbssa@yahoo.de>
 
        * tui/tui-source.c (tui_source_window::show_line_number):

diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 55b66e1bc1670f20b7b692be21ab2873972243d0..40fd00fa7700a8bcaeb1ff7d10e863bb451360b4 100644 (file)
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -252,7 +252,9 @@ tui_source_window_base::show_source_line (int lineno)
 void
 tui_source_window_base::refresh_window ()
 {
-  tui_win_info::refresh_window ();
+  /* tui_win_info::refresh_window would draw the empty background window to
+     the screen, potentially creating a flicker.  */
+  wnoutrefresh (handle.get ());
 
   int pad_width = std::max (m_max_length, width);
   int left_margin = 1 + TUI_EXECINFO_SIZE + extra_margin ();