2001-03-17 Michael Chastain <chastain@redhat.com>

	* win32-nat.c (child_attach): check args for NULL before passing
	to strtoul.  This fixes PR gdb/43.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 10cea66e71e8bfb6618b0d7b2f8caef36b26a2c1..76cf356669d1c60dad1ff7c2608bdf32868a5937 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2001-03-17  Michael Chastain  <chastain@redhat.com>
+
+       * win32-nat.c (child_attach): check args for NULL before passing
+       to strtoul.  This fixes PR gdb/43.
+
 2001-03-17  Mark Kettenis  <kettenis@gnu.org>
 
        * i387-nat.h: Doc Fix.

diff --git a/gdb/win32-nat.c b/gdb/win32-nat.c
index f0d97fa6f2603b1303cbe2890d6f83394226d0d3..277b473456b744b29bac324c95390bbc26d6c010 100644 (file)
--- a/gdb/win32-nat.c
+++ b/gdb/win32-nat.c
@@ -1015,11 +1015,12 @@ static void
 child_attach (char *args, int from_tty)
 {
   BOOL ok;
-  DWORD pid = strtoul (args, 0, 0);
+  DWORD pid;
 
   if (!args)
     error_no_arg ("process-id to attach");
 
+  pid = strtoul (args, 0, 0);
   ok = DebugActiveProcess (pid);
 
   if (!ok)

diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index f0d97fa6f2603b1303cbe2890d6f83394226d0d3..277b473456b744b29bac324c95390bbc26d6c010 100644 (file)
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -1015,11 +1015,12 @@ static void
 child_attach (char *args, int from_tty)
 {
   BOOL ok;
-  DWORD pid = strtoul (args, 0, 0);
+  DWORD pid;
 
   if (!args)
     error_no_arg ("process-id to attach");
 
+  pid = strtoul (args, 0, 0);
   ok = DebugActiveProcess (pid);
 
   if (!ok)