sim: syscall: simplify unknown syscall trace

Since we always include the raw syscall number when tracing, also
including it in the name when it's unknown is redundant.  Simplify
the code by using a constant string.

diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog
index afc1b3aad5b0071a5ab1408d2adfc21e22183105..ecbaad17458ecd369a0b37a6154f83b67a4bea5e 100644 (file)
--- a/sim/common/ChangeLog
+++ b/sim/common/ChangeLog
@@ -1,3 +1,8 @@
+2015-06-18  Mike Frysinger  <vapier@gentoo.org>
+
+       * sim-syscall.c (sim_syscall_multi): Change unknown_syscall to a
+       constant string.
+
 2015-06-18  Mike Frysinger  <vapier@gentoo.org>
 
        * callback.c (cb_target_map_entry, cb_host_map_entry): Change map to

diff --git a/sim/common/sim-syscall.c b/sim/common/sim-syscall.c
index 6f4c8a3fc88039d6f237f67d29a43892c932d4dd..ff5e5d2ed359cba688088e554a229fb928fd7abd 100644 (file)
--- a/sim/common/sim-syscall.c
+++ b/sim/common/sim-syscall.c
@@ -60,7 +60,7 @@ sim_syscall_multi (SIM_CPU *cpu, int func, long arg1, long arg2, long arg3,
   SIM_DESC sd = CPU_STATE (cpu);
   host_callback *cb = STATE_CALLBACK (sd);
   CB_SYSCALL sc;
-  char unknown_syscall[30];
+  const char unknown_syscall[] = "<UNKNOWN SYSCALL>";
   const char *syscall;
 
   CB_SYSCALL_INIT (&sc);
@@ -85,10 +85,7 @@ sim_syscall_multi (SIM_CPU *cpu, int func, long arg1, long arg2, long arg3,
 
   syscall = cb_target_str_syscall (cb, func);
   if (!syscall)
-    {
-      sprintf (unknown_syscall, "syscall_%i", func);
-      syscall = unknown_syscall;
-    }
+    syscall = unknown_syscall;
 
   if (sc.result == -1)
     TRACE_SYSCALL (cpu, "%s[%i](%#lx, %#lx, %#lx) = %li (error = %s[%i])",