savestring: Rename parameter 'size' to 'len'.

It's better to avoid needless confusion, and call string length,
length, instead of size, which is usually used to refer to sizeof of
the string (len+1):

	size_t len = strlen (str);
	size_t size = sizeof (str);

Tested on x86_64 Fedora 17.

2013-02-14  Pedro Alves  <palves@redhat.com>

	* utils.c (savestring): Rename parameter 'size' to 'len'.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9523824442a64ac6739ef6c8266d441095455b09..3e91b36bc0120ae53bc0fbae3615f92d335ac903 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2013-02-14  Pedro Alves  <palves@redhat.com>
+
+       * utils.c (savestring): Rename parameter 'size' to 'len'.
+
 2013-02-14  Pedro Alves  <palves@redhat.com>
            Yufeng Zhang  <yufeng.zhang@arm.com>
 

diff --git a/gdb/utils.c b/gdb/utils.c
index 282ab8b9b0e50bd70172db344ba628be6b3d4d70..408c6ce0888a1e12605a6500e8140a5c612f3f7f 100644 (file)
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -1186,17 +1186,17 @@ myread (int desc, char *addr, int len)
   return orglen;
 }
 
-/* Make a copy of the string at PTR with SIZE characters
+/* Make a copy of the string at PTR with LEN characters
    (and add a null character at the end in the copy).
    Uses malloc to get the space.  Returns the address of the copy.  */
 
 char *
-savestring (const char *ptr, size_t size)
+savestring (const char *ptr, size_t len)
 {
-  char *p = (char *) xmalloc (size + 1);
+  char *p = (char *) xmalloc (len + 1);
 
-  memcpy (p, ptr, size);
-  p[size] = 0;
+  memcpy (p, ptr, len);
+  p[len] = 0;
   return p;
 }