PR c++/71290 - Flexible array member is not diagnosed with -pedantic

gcc/cp/ChangeLog:
	PR c++/71290
	* decl.c (grokdeclarator): Warn on flexible array members.

gcc/testsuite/ChangeLog:
	PR c++/71290
	* g++.dg/ext/flexarray-mangle-2.C: Adjust.
	* g++.dg/ext/flexarray-mangle.C: Same.
	* g++.dg/ext/flexarray-subst.C: Same.
	* g++.dg/ext/flexary10.C: Same.
	* g++.dg/ext/flexary11.C: Same.
	* g++.dg/ext/flexary14.C: Same.
	* g++.dg/ext/flexary16.C: Same.
	* g++.dg/ext/flexary18.C: Same.
	* g++.dg/ext/flexary19.C: Same.
	* g++.dg/ext/flexary7.C: Same.
	* gcc/testsuite/g++.dg/cpp1z/has-unique-obj-representations1.C: Same.
	* gcc/testsuite/g++.dg/ubsan/object-size-1.C: Same.
	* gcc/testsuite/obj-c++.dg/property/at-property-23.mm: Same.

From-SVN: r244910

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 6144ad77450aacd89e287ec4e9494fd5d583dcb8..11c30ca6362e93c4d4e3ba82a327f3640d78ba73 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2017-01-25  Martin Sebor  <msebor@redhat.com>
+
+       PR c++/71290
+       * decl.c (grokdeclarator): Warn on flexible array members.
+
 2017-01-25  Jakub Jelinek  <jakub@redhat.com>
 
        PR c++/78896

diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c
index 4b64ba13377f22afa322a3781fb9082e728d6b35..39e7fbd96003ec8a982dfe4307c9a2ef0d8c9cd3 100644 (file)
--- a/gcc/cp/decl.c
+++ b/gcc/cp/decl.c
@@ -11804,6 +11804,17 @@ grokdeclarator (const cp_declarator *declarator,
              }
            else 
              {
+               /* Array is a flexible member.  */
+               if (in_system_header_at (input_location))
+                 /* Do not warn flexible them in system headers because glibc
+                    uses them.  */;
+               else if (name)
+                 pedwarn (input_location, OPT_Wpedantic,
+                          "ISO C++ forbids flexible array member %<%s%>", name);
+               else
+                 pedwarn (input_location, OPT_Wpedantic,
+                          "ISO C++ forbids flexible array members");
+
                /* Flexible array member has a null domain.  */
                type = build_cplus_array_type (TREE_TYPE (type), NULL_TREE);
              }

diff --git a/gcc/testsuite/g++.dg/cpp1z/has-unique-obj-representations1.C b/gcc/testsuite/g++.dg/cpp1z/has-unique-obj-representations1.C
index 73d80bfc6916f3beda5acdbb2a0225de6b1cc166..bca03a16c41ac98230eb1ce72644b08ae12561a3 100644 (file)
--- a/gcc/testsuite/g++.dg/cpp1z/has-unique-obj-representations1.C
+++ b/gcc/testsuite/g++.dg/cpp1z/has-unique-obj-representations1.C
@@ -1,4 +1,5 @@
 // { dg-do compile { target c++11 } }
+// { dg-additional-options "-Wno-error=pedantic" }
 
 #define INTB (__SIZEOF_INT__ * __CHAR_BIT__)
 struct S { int i : INTB * 3 / 4; S (); };
@@ -7,7 +8,9 @@ struct U { int i : INTB * 3 / 4; int j : INTB / 4; };
 struct V { int i : INTB * 3 / 4; int j : INTB / 4 + 1; };
 struct W {};
 struct X : public W { int i; void bar (); };
-struct Y { char a[3]; char b[]; };
+struct Y {
+  char a[3]; char b[];   // { dg-warning "forbids flexible array member" }
+};
 struct Z { int a; float b; };
 struct A { int i : INTB * 2; int j; };                 // { dg-warning "exceeds its type" }
 union B { long a; unsigned long b; };

diff --git a/gcc/testsuite/g++.dg/ext/flexarray-mangle-2.C b/gcc/testsuite/g++.dg/ext/flexarray-mangle-2.C
index 98bd5f5da0ea00e6fcd8789734cf4c507a53ac16..3abb407fab716bed8d6e906effe036575d3a3448 100644 (file)
--- a/gcc/testsuite/g++.dg/ext/flexarray-mangle-2.C
+++ b/gcc/testsuite/g++.dg/ext/flexarray-mangle-2.C
@@ -1,9 +1,10 @@
 // PR c++/69277 - [6 Regression] ICE mangling a flexible array member
 // { dg-do compile { target c++11 } }
+// { dg-additional-options "-Wno-error=pedantic" }
 
 struct A {
   int n;
-  char a [];
+  char a[];   // { dg-warning "forbids flexible array member" }
 };
 
 // Declare but do not define function templates.

diff --git a/gcc/testsuite/g++.dg/ext/flexarray-mangle.C b/gcc/testsuite/g++.dg/ext/flexarray-mangle.C
index d8a8c0ac59bb74fc9b24ad6012fe93218dfdbcc3..658d9355a9c74899d3bcfac9746368e16318396d 100644 (file)
--- a/gcc/testsuite/g++.dg/ext/flexarray-mangle.C
+++ b/gcc/testsuite/g++.dg/ext/flexarray-mangle.C
@@ -1,9 +1,10 @@
 // PR c++/69277 - [6 Regression] ICE mangling a flexible array member
 // { dg-do compile }
+// { dg-additional-options "-Wno-error=pedantic" }
 
 struct A {
   int n;
-  char a [];
+  char a[];   // { dg-warning "forbids flexible array member" }
 };
 
 // Declare but do not define function templates.

diff --git a/gcc/testsuite/g++.dg/ext/flexarray-subst.C b/gcc/testsuite/g++.dg/ext/flexarray-subst.C
index f6446366165415008dbe9054c3c78e5d4cb98167..6cf03a41af20da6c322748c61966ab1b80c6964a 100644 (file)
--- a/gcc/testsuite/g++.dg/ext/flexarray-subst.C
+++ b/gcc/testsuite/g++.dg/ext/flexarray-subst.C
@@ -1,8 +1,12 @@
 // PR c++/69251 - [6 Regression] ICE (segmentation fault) in unify_array_domain
 // on i686-linux-gnu
 // { dg-do compile }
+// { dg-additional-options "-Wno-error=pedantic" }
 
-struct A { int n; char a[]; };
+struct A {
+  int n;
+  char a[];   // { dg-warning "forbids flexible array member" }
+};
 
 template <class>
 struct B;

diff --git a/gcc/testsuite/g++.dg/ext/flexary10.C b/gcc/testsuite/g++.dg/ext/flexary10.C
index f2868f3bd773f941d854e3c776d6bdd888267958..4d1ff56e49b90fa18173a5b0c73cafd2fe6bdac0 100644 (file)
--- a/gcc/testsuite/g++.dg/ext/flexary10.C
+++ b/gcc/testsuite/g++.dg/ext/flexary10.C
@@ -4,7 +4,7 @@
 
 struct A {
   int n;
-  int a [];
+  int a[];  // { dg-warning "forbids flexible array member" }
 };
 
 struct A foo (void)

diff --git a/gcc/testsuite/g++.dg/ext/flexary11.C b/gcc/testsuite/g++.dg/ext/flexary11.C
index 5bf774fb3b30d9e605768687adfbec4cd19a8f0f..f958cc5555a4fdbc0866fec6bd9af990339e0aed 100644 (file)
--- a/gcc/testsuite/g++.dg/ext/flexary11.C
+++ b/gcc/testsuite/g++.dg/ext/flexary11.C
@@ -4,7 +4,7 @@
 
 struct A {
   int n;
-  char a [];
+  char a[];   // { dg-error "forbids flexible array member" }
 };
 
 void f ()

diff --git a/gcc/testsuite/g++.dg/ext/flexary14.C b/gcc/testsuite/g++.dg/ext/flexary14.C
index 73653575e0a75945fbdd2561c319a6cc693fabcb..add150a0be8042a8be80c936778a1b3dc268c6c9 100644 (file)
--- a/gcc/testsuite/g++.dg/ext/flexary14.C
+++ b/gcc/testsuite/g++.dg/ext/flexary14.C
@@ -9,7 +9,9 @@ struct A<T[]> { typedef int X; };
 
 template <class T> int foo (T&, typename A<T>::X = 0) { return 0; }
 
-struct B { int n, a[]; };
+struct B {
+  int n, a[];     // { dg-error "forbids flexible array member" }
+};
 
 void bar (B *b)
 {

diff --git a/gcc/testsuite/g++.dg/ext/flexary16.C b/gcc/testsuite/g++.dg/ext/flexary16.C
index a3e040d7c1bd0c91744f8d85d55276af718a4935..64a9f5d051510c5ab0b74e08e5600910a4bfdfea 100644 (file)
--- a/gcc/testsuite/g++.dg/ext/flexary16.C
+++ b/gcc/testsuite/g++.dg/ext/flexary16.C
@@ -1,6 +1,7 @@
 // PR c++/71147 - [6 Regression] Flexible array member wrongly rejected
 //   in template
 // { dg-do compile }
+// { dg-options "-Wpedantic -Wno-error=pedantic" }
 
 template <typename>
 struct container
@@ -11,7 +12,7 @@ struct container
 
   struct incomplete {
     int x;
-    elem array[];
+    elem array[];  // { dg-warning "forbids flexible array member" }
   };
 };
 
@@ -26,7 +27,7 @@ struct D: container<T>
 {
   struct S {
     int x;
-    typename container<T>::elem array[];
+    typename container<T>::elem array[];  // { dg-warning "forbids flexible array member" }
   };
 };
 

diff --git a/gcc/testsuite/g++.dg/ext/flexary18.C b/gcc/testsuite/g++.dg/ext/flexary18.C
index 435342541e578358853b0d79d06f6147aac14949..4ab864d991d5d168a0c872285093c497c3e082db 100644 (file)
--- a/gcc/testsuite/g++.dg/ext/flexary18.C
+++ b/gcc/testsuite/g++.dg/ext/flexary18.C
@@ -211,3 +211,5 @@ struct StructUnion9 {                       // { dg-message "in the definition"
     } b2;                                   // { dg-warning "invalid use" }
   } a2;                                     // { dg-message "next member" }
 };
+
+// { dg-prune-output "forbids flexible array member" }

diff --git a/gcc/testsuite/g++.dg/ext/flexary19.C b/gcc/testsuite/g++.dg/ext/flexary19.C
index 27d08ec225d09aad54d2a9d6dece1d096ad3c643..5eaf11b064dcbf44ca0cde053780c592f4ae5f9a 100644 (file)
--- a/gcc/testsuite/g++.dg/ext/flexary19.C
+++ b/gcc/testsuite/g++.dg/ext/flexary19.C
@@ -341,3 +341,4 @@ struct S35
   typedef D D2;
 };
 
+// { dg-prune-output "forbids flexible array member" }

diff --git a/gcc/testsuite/g++.dg/ext/flexary7.C b/gcc/testsuite/g++.dg/ext/flexary7.C
index fdea4d44eaf0dd9202503e12b1b0aaf658cdb57b..1b22f21b2b635e7fd75152151f331fd6c98fa8e2 100644 (file)
--- a/gcc/testsuite/g++.dg/ext/flexary7.C
+++ b/gcc/testsuite/g++.dg/ext/flexary7.C
@@ -5,7 +5,7 @@
 
 struct FlexChar {
     int n;
-    char a[];
+    char a[];       // { dg-warning "forbids flexible array member" }
 };
 
 struct FlexChar ac =
@@ -18,7 +18,7 @@ typedef __WCHAR_TYPE__ wchar_t;
 
 struct FlexWchar {
     int n;
-    wchar_t a[];
+    wchar_t a[];    // { dg-warning "forbids flexible array member" }
 };
 
 struct FlexWchar awc =
@@ -27,7 +27,7 @@ struct FlexWchar awc =
 
 struct FlexInt {
     int n;
-    int a[];
+    int a[];        // { dg-warning "forbids flexible array member" }
 };
 
 // Verify that no warning is issued for the case when a flexible array
@@ -48,7 +48,7 @@ struct FlexInt ai2 =
 template <class T>
 struct FlexT {
     int n;
-    T a[];
+    T a[];          // { dg-warning "forbids flexible array member" }
 };
 
 struct FlexT<char> atc =

diff --git a/gcc/testsuite/g++.dg/ext/pr71290.C b/gcc/testsuite/g++.dg/ext/pr71290.C
new file mode 100644 (file)
index 0000000..e782eb1
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/pr71290.C
@@ -0,0 +1,17 @@
+// PR c++/71290 - [6/7 Regression] Flexible array member is not diagnosed
+// with -pedantic
+
+// { dg-do compile }s
+// { dg-options "-Wall -Wpedantic" }
+
+struct A
+{
+  int i;
+  int arr[];   // { dg-warning "forbids flexible array member .arr." }
+};
+
+template <class T>
+struct B {
+  T n;
+  T a[];       // { dg-warning "forbids flexible array member .a." }
+};

diff --git a/gcc/testsuite/g++.dg/ubsan/object-size-1.C b/gcc/testsuite/g++.dg/ubsan/object-size-1.C
index e6cdefc5c7b1e0f360e21991b3c032a5872d5d82..d2881d69a20b4387b3e3d44823942fc06940bec2 100644 (file)
--- a/gcc/testsuite/g++.dg/ubsan/object-size-1.C
+++ b/gcc/testsuite/g++.dg/ubsan/object-size-1.C
@@ -1,7 +1,10 @@
 // { dg-do compile }
 // { dg-options "-Wpedantic -Wno-error=pedantic -fsanitize=undefined -fpermissive" }
 
-struct T { int c; char d[]; };
+struct T
+{
+  int c; char d[];   // { dg-warning "forbids flexible array member" }
+};
 
 struct T t = { 1, "a" }; // { dg-warning "initialization of a flexible array member " }
 

diff --git a/gcc/testsuite/obj-c++.dg/property/at-property-23.mm b/gcc/testsuite/obj-c++.dg/property/at-property-23.mm
index 035cc8b10fe9ce1f24abf3030e8867791f920d41..0edb37b65cc69bda9ff4fbb0739dbc79f30e2815 100644 (file)
--- a/gcc/testsuite/obj-c++.dg/property/at-property-23.mm
+++ b/gcc/testsuite/obj-c++.dg/property/at-property-23.mm
@@ -14,4 +14,6 @@
 @property int a[8]; /* { dg-error "property can not be an array" } */
 @property int b:8;  /* { dg-error "expected" } */
 @property int c[];  /* { dg-error "property can not be an array" } */
+/* { dg-error "forbids flexible array member" "flexible array member" { target \
+*-*-* } .-1 } */
 @end