mtd: switch to a foreach loop for installation
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thu, 8 Jun 2017 21:05:09 +0000 (23:05 +0200)
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tue, 20 Jun 2017 20:32:36 +0000 (22:32 +0200)
Such a construct allows to bail out if the installation of one of the
program fails, which the current shell-based for loop doesn't do.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
package/mtd/mtd.mk

index 52ad96c11c37a8d27147dfbcd553d5430d6c1666..3df641ef69a0196a1e29c6ae448676c5faa64ee4 100644 (file)
@@ -92,9 +92,9 @@ MTD_TARGETS_$(BR2_PACKAGE_MTD_MKFSUBIFS)      += mkfs.ubifs
 MTD_TARGETS_$(BR2_PACKAGE_MTD_INTEGCK)         += integck
 
 define MTD_INSTALL_TARGET_CMDS
-       for f in $(MTD_TARGETS_y) ; do \
-               $(INSTALL) -D -m 0755 $(@D)/$$f $(TARGET_DIR)/usr/sbin/$${f##*/} ; \
-       done
+       $(foreach f,$(MTD_TARGETS_y), \
+               $(INSTALL) -D -m 0755 $(@D)/$(f) $(TARGET_DIR)/usr/sbin/$(notdir $(f))
+       )
 endef
 
 $(eval $(autotools-package))