ada-lang.c::advance_wild_match improve doc and parameter+temporaries types

This commit fixes the type of one of the parameters as well as a couple
of temporaries.

While at it, the function's description is slightly rewritten to make it
a little clearer what the function does.

gdb/ChangeLog:

        * ada-lang.c (advance_wild_match): Rewrite the function's
        description.  Change the type of target0, t0 and t1 to char.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 80a1d28015ad4b5871da56887110c956dae80871..de66f5aae794ea789113c1805037cd60bcc28671 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-10-09  Joel Brobecker  <brobecker@adacore.com>
+
+       * ada-lang.c (advance_wild_match): Rewrite the function's
+       description.  Change the type of target0, t0 and t1 to char.
+
 2020-10-09  Tom Tromey  <tromey@adacore.com>
 
        * dwarf2/read.c (dwarf2_add_field): Handle signed offsets.

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index fbce14bbe421af584c0a287ffb0d115d3b82a985..be6d0e1d0192a059e46766a1d9b00da20335889f 100644 (file)
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -186,7 +186,7 @@ static int equiv_types (struct type *, struct type *);
 
 static int is_name_suffix (const char *);
 
-static int advance_wild_match (const char **, const char *, int);
+static int advance_wild_match (const char **, const char *, char);
 
 static bool wild_match (const char *name, const char *patn);
 
@@ -5921,18 +5921,18 @@ is_valid_name_for_wild_match (const char *name0)
   return 1;
 }
 
-/* Advance *NAMEP to next occurrence of TARGET0 in the string NAME0
-   that could start a simple name.  Assumes that *NAMEP points into
-   the string beginning at NAME0.  */
+/* Advance *NAMEP to next occurrence in the string NAME0 of the TARGET0
+   character which could start a simple name.  Assumes that *NAMEP points
+   somewhere inside the string beginning at NAME0.  */
 
 static int
-advance_wild_match (const char **namep, const char *name0, int target0)
+advance_wild_match (const char **namep, const char *name0, char target0)
 {
   const char *name = *namep;
 
   while (1)
     {
-      int t0, t1;
+      char t0, t1;
 
       t0 = *name;
       if (t0 == '_')