g3dvl: Update softlinks to nouveau winsys files, related fixes.
authorYounes Manton <younes.m@gmail.com>
Fri, 12 Sep 2008 17:22:43 +0000 (13:22 -0400)
committerYounes Manton <younes.m@gmail.com>
Fri, 12 Sep 2008 17:22:43 +0000 (13:22 -0400)
24 files changed:
src/gallium/state_trackers/g3dvl/vl_r16snorm_mc_buf.c
src/gallium/winsys/g3dvl/nouveau/nouveau_bo.c
src/gallium/winsys/g3dvl/nouveau/nouveau_channel.c
src/gallium/winsys/g3dvl/nouveau/nouveau_context.c
src/gallium/winsys/g3dvl/nouveau/nouveau_device.c
src/gallium/winsys/g3dvl/nouveau/nouveau_dma.c
src/gallium/winsys/g3dvl/nouveau/nouveau_dma.h
src/gallium/winsys/g3dvl/nouveau/nouveau_dri.h
src/gallium/winsys/g3dvl/nouveau/nouveau_drmif.h
src/gallium/winsys/g3dvl/nouveau/nouveau_fence.c
src/gallium/winsys/g3dvl/nouveau/nouveau_grobj.c
src/gallium/winsys/g3dvl/nouveau/nouveau_local.h
src/gallium/winsys/g3dvl/nouveau/nouveau_notifier.c
src/gallium/winsys/g3dvl/nouveau/nouveau_pushbuf.c
src/gallium/winsys/g3dvl/nouveau/nouveau_resource.c
src/gallium/winsys/g3dvl/nouveau/nouveau_screen.c
src/gallium/winsys/g3dvl/nouveau/nouveau_winsys.c
src/gallium/winsys/g3dvl/nouveau/nouveau_winsys_pipe.c
src/gallium/winsys/g3dvl/nouveau/nouveau_winsys_pipe.h
src/gallium/winsys/g3dvl/nouveau/nouveau_winsys_softpipe.c
src/gallium/winsys/g3dvl/nouveau/nv04_surface.c
src/gallium/winsys/g3dvl/nouveau/nv50_surface.c
src/gallium/winsys/g3dvl/xsp_winsys.c
src/libXvMC/Makefile

index 93839e8aa9b7c9e858d6daf63d14d5d47b7ef37c..cfbad08038bd5cb0e97f0f7f49e6522cb35c9786 100644 (file)
@@ -6,10 +6,10 @@
 #include <pipe/p_winsys.h>
 #include <pipe/p_screen.h>
 #include <pipe/p_state.h>
-#include <pipe/p_util.h>
 #include <pipe/p_inlines.h>
 #include <tgsi/tgsi_parse.h>
 #include <tgsi/tgsi_build.h>
+#include <util/u_math.h>
 #include "vl_render.h"
 #include "vl_shader_build.h"
 #include "vl_surface.h"
index 73ac4a4171a354939374d68d361c13aa4489a9ed..1005282dd4d11850b063f1004be45deea333dfdc 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_bo.c
\ No newline at end of file
+../../drm/nouveau/nouveau_bo.c
\ No newline at end of file
index 6c9b2c48d8427e37bc8f1a73fa472b41f9d6cf12..5af82029508bcf7f51f597099203b5a04ff62547 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_channel.c
\ No newline at end of file
+../../drm/nouveau/nouveau_channel.c
\ No newline at end of file
index 5e173c76728c96059002f5b0c7cc0850f44dc498..06a61fcda3e613b24460094f4ad2b03211cc5c4e 100644 (file)
@@ -1,7 +1,7 @@
 #include "pipe/p_defines.h"
 #include "pipe/p_context.h"
 #include "pipe/p_screen.h"
-#include "pipe/p_util.h"
+#include "util/u_memory.h"
 
 #include "nouveau_context.h"
 #include "nouveau_dri.h"
@@ -150,7 +150,7 @@ nouveau_context_create(dri_context_t *dri_context)
                fb_bo = calloc(1, sizeof(struct nouveau_bo_priv));
                fb_bo->drm.offset = nv_screen->front_offset;
                fb_bo->drm.flags = NOUVEAU_MEM_FB;
-               fb_bo->drm.size = nv_screen->front_pitch * 
+               fb_bo->drm.size = nv_screen->front_pitch *
                                  nv_screen->front_height;
                fb_bo->refcount = 1;
                fb_bo->base.flags = NOUVEAU_BO_PIN | NOUVEAU_BO_VRAM;
@@ -280,7 +280,7 @@ nouveau_context_bind(struct nouveau_context *nv, dri_drawable_t *dri_drawable)
 {
        assert(nv);
        assert(dri_drawable);
-       
+
        if (nv->dri_drawable != dri_drawable)
        {
                nv->dri_drawable = dri_drawable;
@@ -294,9 +294,9 @@ int
 nouveau_context_unbind(struct nouveau_context *nv)
 {
        assert(nv);
-       
+
        nv->dri_drawable = NULL;
-       
+
        return 0;
 }
 
@@ -306,20 +306,20 @@ int bind_pipe_drawable(struct pipe_context *pipe, Drawable drawable)
 {
        struct nouveau_context  *nv;
        dri_drawable_t          *dri_drawable;
-       
+
        nv = pipe->priv;
-       
+
        driCreateDrawable(nv->nv_screen->dri_screen, drawable, &dri_drawable);
-       
+
        nouveau_context_bind(nv, dri_drawable);
-       
+
        return 0;
 }
 
 int unbind_pipe_drawable(struct pipe_context *pipe)
 {
        nouveau_context_unbind(pipe->priv);
-       
+
        return 0;
 }
 
@@ -329,15 +329,15 @@ struct pipe_context* create_pipe_context(Display *display, int screen)
        dri_framebuffer_t       dri_framebuf;
        dri_context_t           *dri_context;
        struct nouveau_context  *nv;
-       
+
        driCreateScreen(display, screen, &dri_screen, &dri_framebuf);
        driCreateContext(dri_screen, XDefaultVisual(display, screen), &dri_context);
-       
+
        nouveau_screen_create(dri_screen, &dri_framebuf);
        nouveau_context_create(dri_context);
-       
+
        nv = dri_context->private;
-       
+
        return nv->nvc->pctx[nv->pctx_id];
 }
 
@@ -348,15 +348,15 @@ int destroy_pipe_context(struct pipe_context *pipe)
        struct nouveau_context  *nv;
        dri_screen_t            *dri_screen;
        dri_context_t           *dri_context;
-       
+
        assert(pipe);
-       
+
        screen = pipe->screen;
        winsys = pipe->winsys;
        nv = pipe->priv;
        dri_context = nv->dri_context;
        dri_screen = dri_context->dri_screen;
-       
+
        pipe->destroy(pipe);
        screen->destroy(screen);
        free(winsys);
@@ -365,7 +365,6 @@ int destroy_pipe_context(struct pipe_context *pipe)
        nouveau_screen_destroy(dri_screen);
        driDestroyContext(dri_context);
        driDestroyScreen(dri_screen);
-       
+
        return 0;
 }
-
index 47d52dafa895077f293f86aab1063e14d2511a71..63f1fa040c70aecddaa82e9bc11a002f09d0e0b9 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_device.c
\ No newline at end of file
+../../drm/nouveau/nouveau_device.c
\ No newline at end of file
index 45078c964f44107f67f031e74623c327fff72cc6..cd0d32e53736e7eb66164acb38ac96a8377ef154 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_dma.c
\ No newline at end of file
+../../drm/nouveau/nouveau_dma.c
\ No newline at end of file
index 6b9ec7774176b9524158a756c3fd2c58fc017156..e6c7d4bc96538de4fc87919cf70593471e668c1d 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_dma.h
\ No newline at end of file
+../../drm/nouveau/nouveau_dma.h
\ No newline at end of file
index 0e6c9fce3557752a3b8468c06014f37e32e771ea..c8f9dbdc3a87c523de77efdf92ece32208ef4f03 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_dri.h
\ No newline at end of file
+../../drm/nouveau/nouveau_dri.h
\ No newline at end of file
index 473b7d4812db3cdd0971f1b7bc11ce140c133b6e..27082c9d34c0fcd82fc289e911a36d3a847a5a23 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_drmif.h
\ No newline at end of file
+../../drm/nouveau/nouveau_drmif.h
\ No newline at end of file
index ef1f0c6afe198c33991f794697255e33d9ad4364..51a50527e6dcd010cf32fc5c6f1322a52ba776e8 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_fence.c
\ No newline at end of file
+../../drm/nouveau/nouveau_fence.c
\ No newline at end of file
index 428186544c60255271b752ec7d67c04b7ad75aa2..db17c72e6d711b99f507bad0c32cb99776aebc5a 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_grobj.c
\ No newline at end of file
+../../drm/nouveau/nouveau_grobj.c
\ No newline at end of file
index 6b878aad224bc4d4fd0b1332c18c0226320521c6..4e9d3042cb5af9e2e6189cb259661db12080a17e 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_local.h
\ No newline at end of file
+../../drm/nouveau/nouveau_local.h
\ No newline at end of file
index 3024a612a7af5213a46992a232c969fb329a76bd..703bc3ce4ab9b87d8483cdf745ba5fa29136478e 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_notifier.c
\ No newline at end of file
+../../drm/nouveau/nouveau_notifier.c
\ No newline at end of file
index dae31d9799863efe34db8d1703e0bd0bf94c82f1..4ac137cadad9c44eff0d57c6bbc492bb1de89160 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_pushbuf.c
\ No newline at end of file
+../../drm/nouveau/nouveau_pushbuf.c
\ No newline at end of file
index e0d71e9d2bfe60aa013da03089544585af8ab7b5..2241af328ffc76a47390a1c2309896f86467887d 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_resource.c
\ No newline at end of file
+../../drm/nouveau/nouveau_resource.c
\ No newline at end of file
index daea3fff680037f99d87905f6892ca1d6ea7f6cf..f80d00050c8d5959420362339755d8b912fe03fc 100644 (file)
@@ -1,5 +1,5 @@
 #include "pipe/p_context.h"
-#include "pipe/p_util.h"
+#include "util/u_memory.h"
 #include "nouveau_context.h"
 #include <nouveau_drm.h>
 #include "nouveau_dri.h"
@@ -23,11 +23,11 @@ int nouveau_check_dri_drm_ddx(dri_version_t *dri, dri_version_t *drm, dri_versio
        static const dri_version_t ddx_expected = {0, 0, NOUVEAU_DRM_HEADER_PATCHLEVEL};
        static const dri_version_t dri_expected = {4, 0, 0};
        static const dri_version_t drm_expected = {0, 0, NOUVEAU_DRM_HEADER_PATCHLEVEL};
-       
+
        assert(dri);
        assert(drm);
        assert(ddx);
-       
+
        if (dri->major != dri_expected.major || dri->minor < dri_expected.minor)
        {
                NOUVEAU_ERR("Unexpected DRI version.\n");
@@ -43,17 +43,17 @@ int nouveau_check_dri_drm_ddx(dri_version_t *dri, dri_version_t *drm, dri_versio
                NOUVEAU_ERR("Unexpected DDX version.\n");
                return 1;
        }
-       
+
        return 0;
 }
 
 int
 nouveau_screen_create(dri_screen_t *dri_screen, dri_framebuffer_t *dri_framebuf)
-{      
+{
        struct nouveau_dri      *nv_dri = dri_framebuf->private;
        struct nouveau_screen   *nv_screen;
        int                     ret;
-       
+
        if (nouveau_check_dri_drm_ddx(&dri_screen->dri, &dri_screen->drm, &dri_screen->ddx))
                return 1;
 
@@ -89,4 +89,3 @@ nouveau_screen_destroy(dri_screen_t *dri_screen)
 
        FREE(nv_screen);
 }
-
index 43de49b98bbcb4193e820b78866c18cc7a627bcb..ce4052d5572d334f5c14bfe2c3afd0bcaffbc5ef 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_winsys.c
\ No newline at end of file
+../../drm/nouveau/nouveau_winsys.c
\ No newline at end of file
index b835bd576068dc35f96a8e86729150f0476a3c28..5d5380c2502e773c5ca5ecf9008d413b5d982533 100644 (file)
@@ -1,7 +1,7 @@
 #include "pipe/p_winsys.h"
 #include "pipe/p_defines.h"
-#include "pipe/p_util.h"
 #include "pipe/p_inlines.h"
+#include "util/u_memory.h"
 
 #include "nouveau_context.h"
 #include "nouveau_local.h"
@@ -29,7 +29,7 @@ static struct pipe_surface *
 nouveau_surface_alloc(struct pipe_winsys *ws)
 {
        struct pipe_surface *surf;
-       
+
        surf = CALLOC_STRUCT(pipe_surface);
        if (!surf)
                return NULL;
@@ -59,10 +59,10 @@ nouveau_surface_alloc_storage
 )
 {
        const unsigned int ALIGNMENT = 256;
-       
+
        assert(pws);
        assert(surface);
-       
+
        surface->width = width;
        surface->height = height;
        surface->format = format;
@@ -72,7 +72,7 @@ nouveau_surface_alloc_storage
        surface->stride = round_up(surface->nblocksx * surface->block.size, ALIGNMENT);
        surface->usage = flags;
        surface->buffer = pws->buffer_create(pws, ALIGNMENT, PIPE_BUFFER_USAGE_PIXEL, surface->stride * surface->nblocksy);
-       
+
        return 0;
 }
 
@@ -258,4 +258,3 @@ nouveau_create_pipe_winsys(struct nouveau_context *nv)
 
        return &nvpws->pws;
 }
-
index 264716fef04eae270ca0b89c2acdbd9d05037325..9d9460883e048090d16e6e27e834131b444cce58 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_winsys_pipe.h
\ No newline at end of file
+../../drm/nouveau/nouveau_winsys_pipe.h
\ No newline at end of file
index 83faccde9699aef249bd308474afaf69912742b6..ec613ecbf65640fc3864e20e5f0b6067b36a155f 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nouveau_winsys_softpipe.c
\ No newline at end of file
+../../drm/nouveau/nouveau_winsys_softpipe.c
\ No newline at end of file
index e05f0671d63521ebd20c8e02a81d5b7980d477b8..4455d8f9243d7e775ea8c75ce319f68b92cc3cc1 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nv04_surface.c
\ No newline at end of file
+../../drm/nouveau/nv04_surface.c
\ No newline at end of file
index 3850748229d07acb2838d451b16191f957d8e38b..19f102001e927e15504848b568fee6a7bbd22e35 120000 (symlink)
@@ -1 +1 @@
-../../dri/nouveau/nv50_surface.c
\ No newline at end of file
+../../drm/nouveau/nv50_surface.c
\ No newline at end of file
index 0100fe37bdbc1565f4a58324e8c1dae967cf26aa..42e7841df85dc81dab394122423bb18a3c9fa905 100644 (file)
@@ -2,8 +2,8 @@
 #include <X11/Xutil.h>
 #include <pipe/p_winsys.h>
 #include <pipe/p_state.h>
-#include <pipe/p_util.h>
 #include <pipe/p_inlines.h>
+#include <util/u_memory.h>
 #include <softpipe/sp_winsys.h>
 
 /* pipe_winsys implementation */
@@ -33,79 +33,79 @@ struct xsp_buffer
 static struct pipe_buffer* xsp_buffer_create(struct pipe_winsys *pws, unsigned alignment, unsigned usage, unsigned size)
 {
        struct xsp_buffer *buffer;
-       
+
        assert(pws);
-       
+
        buffer = calloc(1, sizeof(struct xsp_buffer));
        buffer->base.refcount = 1;
        buffer->base.alignment = alignment;
        buffer->base.usage = usage;
        buffer->base.size = size;
        buffer->data = align_malloc(size, alignment);
-       
+
        return (struct pipe_buffer*)buffer;
 }
 
 static struct pipe_buffer* xsp_user_buffer_create(struct pipe_winsys *pws, void *data, unsigned size)
 {
        struct xsp_buffer *buffer;
-       
+
        assert(pws);
-       
+
        buffer = calloc(1, sizeof(struct xsp_buffer));
        buffer->base.refcount = 1;
        buffer->base.size = size;
        buffer->is_user_buffer = TRUE;
        buffer->data = data;
-       
+
        return (struct pipe_buffer*)buffer;
 }
 
 static void* xsp_buffer_map(struct pipe_winsys *pws, struct pipe_buffer *buffer, unsigned flags)
 {
        struct xsp_buffer *xsp_buf = (struct xsp_buffer*)buffer;
-       
+
        assert(pws);
        assert(buffer);
-       
+
        xsp_buf->mapped_data = xsp_buf->data;
-       
+
        return xsp_buf->mapped_data;
 }
 
 static void xsp_buffer_unmap(struct pipe_winsys *pws, struct pipe_buffer *buffer)
 {
        struct xsp_buffer *xsp_buf = (struct xsp_buffer*)buffer;
-       
+
        assert(pws);
        assert(buffer);
-       
+
        xsp_buf->mapped_data = NULL;
 }
 
 static void xsp_buffer_destroy(struct pipe_winsys *pws, struct pipe_buffer *buffer)
 {
        struct xsp_buffer *xsp_buf = (struct xsp_buffer*)buffer;
-       
+
        assert(pws);
        assert(buffer);
-       
+
        if (!xsp_buf->is_user_buffer)
                align_free(xsp_buf->data);
-       
+
        free(xsp_buf);
 }
 
 static struct pipe_surface* xsp_surface_alloc(struct pipe_winsys *pws)
 {
        struct pipe_surface *surface;
-       
+
        assert(pws);
-       
+
        surface = calloc(1, sizeof(struct pipe_surface));
        surface->refcount = 1;
        surface->winsys = pws;
-       
+
        return surface;
 }
 
@@ -127,10 +127,10 @@ static int xsp_surface_alloc_storage
 )
 {
        const unsigned int ALIGNMENT = 1;
-       
+
        assert(pws);
        assert(surface);
-       
+
        surface->width = width;
        surface->height = height;
        surface->format = format;
@@ -140,28 +140,28 @@ static int xsp_surface_alloc_storage
        surface->stride = round_up(surface->nblocksx * surface->block.size, ALIGNMENT);
        surface->usage = flags;
        surface->buffer = pws->buffer_create(pws, ALIGNMENT, PIPE_BUFFER_USAGE_PIXEL, surface->stride * surface->nblocksy);
-       
+
        return 0;
 }
 
 static void xsp_surface_release(struct pipe_winsys *pws, struct pipe_surface **surface)
 {
        struct pipe_surface *s;
-       
+
        assert(pws);
        assert(surface);
        assert(*surface);
-       
+
        s = *surface;
-       
+
        s->refcount--;
-       
+
        if (s->refcount == 0)
        {
                pipe_buffer_reference(pws, &s->buffer, NULL);
                free(s);
        }
-       
+
        *surface = NULL;
 }
 
@@ -176,7 +176,7 @@ static int xsp_fence_signalled(struct pipe_winsys *pws, struct pipe_fence_handle
 {
        assert(pws);
        assert(fence);
-       
+
        return 0;
 }
 
@@ -184,30 +184,30 @@ static int xsp_fence_finish(struct pipe_winsys *pws, struct pipe_fence_handle *f
 {
        assert(pws);
        assert(fence);
-       
+
        return 0;
 }
 
 static void xsp_flush_frontbuffer(struct pipe_winsys *pws, struct pipe_surface *surface, void *context_private)
-{      
+{
        struct xsp_pipe_winsys  *xsp_winsys;
        struct xsp_context      *xsp_context;
-       
+
        assert(pws);
        assert(surface);
        assert(context_private);
-       
+
        xsp_winsys = (struct xsp_pipe_winsys*)pws;
        xsp_context = (struct xsp_context*)context_private;
-       
+
        if (!xsp_context->drawable_bound)
                return;
-       
+
        xsp_winsys->fbimage.width = surface->width;
        xsp_winsys->fbimage.height = surface->height;
        xsp_winsys->fbimage.bytes_per_line = surface->width * (xsp_winsys->fbimage.bits_per_pixel >> 3);
        xsp_winsys->fbimage.data = pipe_surface_map(surface, 0);
-       
+
        XPutImage
        (
                xsp_context->display,
@@ -236,25 +236,25 @@ static const char* xsp_get_name(struct pipe_winsys *pws)
 int bind_pipe_drawable(struct pipe_context *pipe, Drawable drawable)
 {
        struct xsp_context *xsp_context;
-       
+
        assert(pipe);
-       
+
        xsp_context = pipe->priv;
        xsp_context->drawable = drawable;
        xsp_context->drawable_bound = 1;
-       
+
        return 0;
 }
 
 int unbind_pipe_drawable(struct pipe_context *pipe)
 {
        struct xsp_context *xsp_context;
-       
+
        assert(pipe);
-       
+
        xsp_context = pipe->priv;
        xsp_context->drawable_bound = 0;
-       
+
        return 0;
 }
 
@@ -264,9 +264,9 @@ struct pipe_context* create_pipe_context(Display *display, int screen)
        struct xsp_context      *xsp_context;
        struct pipe_screen      *sp_screen;
        struct pipe_context     *sp_pipe;
-       
+
        assert(display);
-       
+
        xsp_winsys = calloc(1, sizeof(struct xsp_pipe_winsys));
        xsp_winsys->base.buffer_create = xsp_buffer_create;
        xsp_winsys->base.user_buffer_create = xsp_user_buffer_create;
@@ -281,7 +281,7 @@ struct pipe_context* create_pipe_context(Display *display, int screen)
        xsp_winsys->base.fence_finish = xsp_fence_finish;
        xsp_winsys->base.flush_frontbuffer = xsp_flush_frontbuffer;
        xsp_winsys->base.get_name = xsp_get_name;
-       
+
        {
                /* XXX: Can't use the returned XImage* directly,
                since we don't have control over winsys destruction
@@ -299,22 +299,22 @@ struct pipe_context* create_pipe_context(Display *display, int screen)
                        32,
                        0
                );
-               
+
                memcpy(&xsp_winsys->fbimage, template, sizeof(XImage));
                XInitImage(&xsp_winsys->fbimage);
-               
+
                XDestroyImage(template);
        }
-       
+
        sp_screen = softpipe_create_screen((struct pipe_winsys*)xsp_winsys);
        sp_pipe = softpipe_create(sp_screen, (struct pipe_winsys*)xsp_winsys, NULL);
-       
+
        xsp_context = calloc(1, sizeof(struct xsp_context));
        xsp_context->display = display;
        xsp_context->screen = screen;
-       
+
        sp_pipe->priv = xsp_context;
-       
+
        return sp_pipe;
 }
 
@@ -322,16 +322,15 @@ int destroy_pipe_context(struct pipe_context *pipe)
 {
        struct pipe_screen *screen;
        struct pipe_winsys *winsys;
-       
+
        assert(pipe);
-       
+
        screen = pipe->screen;
        winsys = pipe->winsys;
        free(pipe->priv);
        pipe->destroy(pipe);
        screen->destroy(screen);
        free(winsys);
-       
+
        return 0;
 }
-
index 8565d271c70b478adcc5c2e2a98d14136b2e4964..4de26e96202b65b9499d46b9ce48ce541153238a 100644 (file)
@@ -47,7 +47,7 @@ endif
 all: ${TARGET}
 
 ifeq (${DRIVER}, softpipe)
-${TARGET}: g3dvl
+${TARGET}: ${OBJECTS} g3dvl
        $(CC) ${LDFLAGS} -shared -Wl,-soname,${SONAME} -o $@ ${OBJECTS} ${LIBS}
 
 g3dvl: