symbols-check: discard platform symbols early
authorEric Engestrom <eric.engestrom@intel.com>
Sat, 3 Aug 2019 17:21:26 +0000 (18:21 +0100)
committerEric Engestrom <eric.engestrom@intel.com>
Sun, 4 Aug 2019 10:06:27 +0000 (11:06 +0100)
(as the comment there already claimed)

Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Tested-by: Vinson Lee <vlee@freedesktop.org>
bin/symbols-check.py

index 7b1a086e95f3378160f8c90707d3c3dcba86b25e..39ad1451852ef8b58481a854fa874311170b2dc7 100644 (file)
@@ -27,6 +27,8 @@ def get_symbols(nm, lib):
                                      stderr=open(os.devnull, 'w')).decode("ascii")
     for line in output.splitlines():
         (_, _, symbol_name) = line.split()
+        if symbol_name in PLATFORM_SYMBOLS:
+            continue
         symbols.append(symbol_name)
     return symbols
 
@@ -97,8 +99,6 @@ def main():
             continue
         if symbol in optional_symbols:
             continue
-        if symbol in PLATFORM_SYMBOLS:
-            continue
         unknown_symbols.append(symbol)
 
     missing_symbols = [