Revert "mesa/main: remove ARB suffix from glGetnTexImage"
authorEmil Velikov <emil.l.velikov@gmail.com>
Mon, 10 Dec 2018 17:54:23 +0000 (17:54 +0000)
committerEmil Velikov <emil.l.velikov@gmail.com>
Thu, 24 Jan 2019 18:13:25 +0000 (18:13 +0000)
This reverts commit f1998e15ffccf260552bf559abe1a733a8ce990e.

This changes the ABI, such that glGetnTexImageARB entry-point from the
GLAPI gets removed. Thus accessing many functions by offset (as we do)
will result in getting the wrong one.

Follow-up work will swap the by-offset handling, but for now revert
this patch.

Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
src/mapi/glapi/gen/ARB_robustness.xml
src/mapi/glapi/gen/gl_API.xml
src/mesa/main/texgetimage.c
src/mesa/main/texgetimage.h

index 47c417390dfb9d54147edf7462a8411c28707d0c..1f6ac4696b6b2bfe751f4f5a6dccf0949a9f0d4c 100644 (file)
@@ -73,7 +73,7 @@
         <param name="pattern" type="GLubyte *" output="true"/>
     </function>
 
-    <function name="GetnTexImageARB" alias="GetnTexImage">
+    <function name="GetnTexImageARB">
         <param name="target" type="GLenum"/>
         <param name="level" type="GLint"/>
         <param name="format" type="GLenum"/>
index f4d0808f13b9da654d1597f0e74dff259e3bda73..929e5f6b0240cf58bf950625caa909650b49b933 100644 (file)
         <glx sop="135" dimensions_in_reply="true"/>
     </function>
 
-    <function name="GetnTexImage">
-        <param name="target" type="GLenum"/>
-        <param name="level" type="GLint"/>
-        <param name="format" type="GLenum"/>
-        <param name="type" type="GLenum"/>
-        <param name="bufSize" type="GLsizei"/>
-        <param name="img" type="GLvoid *" output="true"/>
-    </function>
-
     <function name="GetTexParameterfv" es1="1.1" es2="2.0">
         <param name="target" type="GLenum"/>
         <param name="pname" type="GLenum"/>
index dabfcd06a5297828cbcce5a0c08aebdabd0bc9e7..bb4f7006618d44487ac2a40c36d54ed60448fcb9 100644 (file)
@@ -1440,11 +1440,11 @@ get_texture_image(struct gl_context *ctx,
 
 
 void GLAPIENTRY
-_mesa_GetnTexImage(GLenum target, GLint level, GLenum format, GLenum type,
-                   GLsizei bufSize, GLvoid *pixels)
+_mesa_GetnTexImageARB(GLenum target, GLint level, GLenum format, GLenum type,
+                      GLsizei bufSize, GLvoid *pixels)
 {
    GET_CURRENT_CONTEXT(ctx);
-   static const char *caller = "glGetnTexImage";
+   static const char *caller = "glGetnTexImageARB";
    GLsizei width, height, depth;
    struct gl_texture_object *texObj;
 
index 9a5874300e7ce6a8839a4f9d65753b19269b5332..3928e7abb7b7b23ce1984bddf536bd7abb1e6136 100644 (file)
@@ -56,8 +56,8 @@ extern void GLAPIENTRY
 _mesa_GetTexImage( GLenum target, GLint level,
                    GLenum format, GLenum type, GLvoid *pixels );
 extern void GLAPIENTRY
-_mesa_GetnTexImage(GLenum target, GLint level, GLenum format,
-                   GLenum type, GLsizei bufSize, GLvoid *pixels);
+_mesa_GetnTexImageARB( GLenum target, GLint level, GLenum format,
+                       GLenum type, GLsizei bufSize, GLvoid *pixels );
 extern void GLAPIENTRY
 _mesa_GetTextureImage(GLuint texture, GLint level, GLenum format,
                       GLenum type, GLsizei bufSize, GLvoid *pixels);