make: disable guile support
authorRyan Barnett <ryanbarnett3@gmail.com>
Sun, 20 Sep 2015 21:10:30 +0000 (16:10 -0500)
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Mon, 12 Oct 2015 21:55:44 +0000 (23:55 +0200)
When building in a static only configuration with guile package
enabled, the following error happens:

 gc_pthread_redirects.h:37:22: fatal error: dlfcn.h: No such file or
 directory
   #   include <dlfcn.h>

The file gc_pthread_redirects.h comes from bdwgc, which gets built
before make in the autobuild test case indicated below. This header
file is known to incorrectly include <dlfcn.h>, unless GC_NO_DLOPEN is
specified.

IF GC_NO_DLOPEN is defined, another issue arises due to libguile and
libintl both defining locale_charset.

We could have kept the guile support enabled only on dynamic library
configurations, and disable it only for static library
configurations. However, the need for guile support in make on the
target seems highly unlikely, so we'd better simply disabling guile
support, which this commit does.

Fixes:

  http://autobuild.buildroot.net/results/814/8143ae0afac139845e5016058d85c800dc8527ad

[Thomas: tweak commit log.]

Signed-off-by: Ryan Barnett <ryanbarnett3@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
package/make/make.mk

index ebfa2f0319c0ee72267f5ea44fd3dae5d0375d61..20702dc23719d312eb9de25af1cce5e3cb3f4b72 100644 (file)
@@ -11,16 +11,11 @@ MAKE_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 MAKE_LICENSE = GPLv3+
 MAKE_LICENSE_FILES = COPYING
 
+MAKE_CONF_OPTS = --without-guile
+
 # Disable the 'load' operation for static builds since it needs dlopen
 ifeq ($(BR2_STATIC_LIBS),y)
 MAKE_CONF_OPTS += --disable-load
 endif
 
-ifeq ($(BR2_PACKAGE_GUILE),y)
-MAKE_DEPENDENCIES += guile
-MAKE_CONF_OPTS += --with-guile
-else
-MAKE_CONF_OPTS += --without-guile
-endif
-
 $(eval $(autotools-package))