re PR middle-end/27781 (weak-attribute over-optimisation)

2006-06-16  Richard Guenther  <rguenther@suse.de>

	PR tree-optimization/27781
	* Makefile.in (ipa-pure-const.o): Add $(TARGET_H) dependency.
	* ipa-pure-const.c (target.h): Include.
	(analyze_function): Do not analyze functions that do not
        bind locally.

	* gcc.dg/tree-ssa/pr27781.c: New testcase.

From-SVN: r114681

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 9abc3e8fbe6d4d4fd055b6117a35decb8eb1e1d9..3fffbff3f54bd526e09e29c30f567792b70325aa 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,11 @@
+2006-06-16  Richard Guenther  <rguenther@suse.de>
+
+       PR tree-optimization/27781
+       * Makefile.in (ipa-pure-const.o): Add $(TARGET_H) dependency.
+       * ipa-pure-const.c (target.h): Include.
+       (analyze_function): Do not analyze functions that do not
+       bind locally.
+
 2006-06-15  Andrew MacLeod  <amacleod@redhat.com>
        
        PR middle-end/27793

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index e358be789253f0c06e2cc2f664ac699b745d9e16..4ffbd5588d1ff8f0de8310ce14314a9ffd8e9a38 100644 (file)
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -2309,7 +2309,7 @@ ipa-reference.o : ipa-reference.c $(CONFIG_H) $(SYSTEM_H) \
    $(TREE_GIMPLE_H) $(CGRAPH_H) output.h $(FLAGS_H) tree-pass.h $(DIAGNOSTIC_H)  
 ipa-pure-const.o : ipa-pure-const.c $(CONFIG_H) $(SYSTEM_H) \
    coretypes.h $(TM_H) $(TREE_H) $(TREE_FLOW_H) $(TREE_INLINE_H) langhooks.h \
-   pointer-set.h $(GGC_H) $(IPA_UTILS_H) $(C_COMMON_H) \
+   pointer-set.h $(GGC_H) $(IPA_UTILS_H) $(C_COMMON_H) $(TARGET_H) \
    $(TREE_GIMPLE_H) $(CGRAPH_H) output.h $(FLAGS_H) tree-pass.h $(DIAGNOSTIC_H)  
 ipa-type-escape.o : ipa-type-escape.c $(CONFIG_H) $(SYSTEM_H) \
    coretypes.h $(TM_H) $(TREE_H) $(TREE_FLOW_H) $(TREE_INLINE_H) langhooks.h \

diff --git a/gcc/ipa-pure-const.c b/gcc/ipa-pure-const.c
index 079af5e12e2e7e8b42088c613b2f90045ec07011..041cf2984b116ab744b6937de1639bf84f36f05e 100644 (file)
--- a/gcc/ipa-pure-const.c
+++ b/gcc/ipa-pure-const.c
@@ -51,6 +51,7 @@ Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
 #include "timevar.h"
 #include "diagnostic.h"
 #include "langhooks.h"
+#include "target.h"
 
 static struct pointer_set_t *visited_nodes;
 
@@ -499,9 +500,11 @@ analyze_function (struct cgraph_node *fn)
   l->pure_const_state = IPA_CONST;
   l->state_set_in_source = false;
 
-  /* If this is a volatile function, do not touch this unless it has
-     been marked as const or pure by the front end.  */
-  if (TREE_THIS_VOLATILE (decl))
+  /* If this function does not return normally or does not bind local,
+     do not touch this unless it has been marked as const or pure by the
+     front end.  */
+  if (TREE_THIS_VOLATILE (decl)
+      || !targetm.binds_local_p (decl))
     {
       l->pure_const_state = IPA_NEITHER;
       return;

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index c538d132f7139504d1a96b71a394f3efe59b49c7..6570fe14e35f3c80f1cac7e68f8798155e8f9bd2 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2006-06-16  Richard Guenther  <rguenther@suse.de>
+
+       PR tree-optimization/27781
+       * gcc.dg/tree-ssa/pr27781.c: New testcase.
+
 2006-06-15  Thomas Koenig <Thomas.Koenig@online.de>
 
        * gfortran.dg/allocate_zerosize_2.f90:  New test case.

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr27781.c b/gcc/testsuite/gcc.dg/tree-ssa/pr27781.c
new file mode 100644 (file)
index 0000000..0e1a02a
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/tree-ssa/pr27781.c
@@ -0,0 +1,17 @@
+/* { dg-do compile } */
+/* { dg-require-weak "" } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+
+void __attribute__((weak)) func(void)
+{
+    /* no code */
+}
+
+int main()
+{
+    func();
+    return 0;
+}
+
+/* { dg-final { scan-tree-dump "func \\(\\);" "optimized" } } */
+/* { dg-final { cleanup-tree-dump "optimized" } } */