calls.c (emit_library_call_value_1): Invoke promote_function_mode hook on libcall...

2011-05-04  Andreas Krebbel  <Andreas.Krebbel@de.ibm.com>

	* calls.c (emit_library_call_value_1): Invoke
	promote_function_mode hook on libcall arguments.
	* explow.c (promote_function_mode, promote_mode): Handle TYPE
	argument being NULL.
	* targhooks.c (default_promote_function_mode): Lisewise.
	* config/s390/s390.c (s390_promote_function_mode): Likewise.
	* config/sparc/sparc.c (sparc_promote_function_mode): Likewise.

	* doc/tm.texi: Document that TYPE argument might be NULL.

From-SVN: r173371

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index c77c1396a25115087da6537015f13da594639985..1f6d535c81e52abb5ec0c8056b03a441aff81fc6 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,15 @@
+2011-05-04  Andreas Krebbel  <Andreas.Krebbel@de.ibm.com>
+
+       * calls.c (emit_library_call_value_1): Invoke
+       promote_function_mode hook on libcall arguments.
+       * explow.c (promote_function_mode, promote_mode): Handle TYPE
+       argument being NULL.
+       * targhooks.c (default_promote_function_mode): Lisewise.
+       * config/s390/s390.c (s390_promote_function_mode): Likewise.
+       * config/sparc/sparc.c (sparc_promote_function_mode): Likewise.
+
+       * doc/tm.texi: Document that TYPE argument might be NULL.
+
 2011-05-04  Stuart Henderson  <shenders@gcc.gnu.org>
 
        * config/bfin/bfin.c (bfin_cpus): Update silicon revisions.

diff --git a/gcc/calls.c b/gcc/calls.c
index 98f3009905a55a7d3ab1c27390939d91922de446..44a16ff63ff1d0c3cb4d01a3ec453f82e76f410f 100644 (file)
--- a/gcc/calls.c
+++ b/gcc/calls.c
@@ -3477,6 +3477,7 @@ emit_library_call_value_1 (int retval, rtx orgfun, rtx value,
     {
       rtx val = va_arg (p, rtx);
       enum machine_mode mode = (enum machine_mode) va_arg (p, int);
+      int unsigned_p = 0;
 
       /* We cannot convert the arg value to the mode the library wants here;
         must do it earlier where we know the signedness of the arg.  */
@@ -3524,9 +3525,9 @@ emit_library_call_value_1 (int retval, rtx orgfun, rtx value,
          val = force_operand (XEXP (slot, 0), NULL_RTX);
        }
 
-      argvec[count].value = val;
+      mode = promote_function_mode (NULL_TREE, mode, &unsigned_p, NULL_TREE, 0);
       argvec[count].mode = mode;
-
+      argvec[count].value = convert_modes (mode, GET_MODE (val), val, unsigned_p);
       argvec[count].reg = targetm.calls.function_arg (&args_so_far, mode,
                                                      NULL_TREE, true);
 

diff --git a/gcc/config/s390/s390.c b/gcc/config/s390/s390.c
index e0f98e686e387145c4a337cd6866f1d9202ba1b1..932ad31cfb7c8813ec11626a40364fe9aef9545f 100644 (file)
--- a/gcc/config/s390/s390.c
+++ b/gcc/config/s390/s390.c
@@ -8742,7 +8742,7 @@ s390_promote_function_mode (const_tree type, enum machine_mode mode,
   if (INTEGRAL_MODE_P (mode)
       && GET_MODE_SIZE (mode) < UNITS_PER_LONG)
     {
-      if (POINTER_TYPE_P (type))
+      if (type != NULL_TREE && POINTER_TYPE_P (type))
        *punsignedp = POINTERS_EXTEND_UNSIGNED;
       return Pmode;
     }

diff --git a/gcc/config/sparc/sparc.c b/gcc/config/sparc/sparc.c
index 44ba5f77002d65022dbee41c6be96774f71e6e96..a3bab331910b6811f2326de0b982655c83e37014 100644 (file)
--- a/gcc/config/sparc/sparc.c
+++ b/gcc/config/sparc/sparc.c
@@ -4983,13 +4983,13 @@ init_cumulative_args (struct sparc_args *cum, tree fntype,
 /* Handle promotion of pointer and integer arguments.  */
 
 static enum machine_mode
-sparc_promote_function_mode (const_tree type ATTRIBUTE_UNUSED,
+sparc_promote_function_mode (const_tree type,
                              enum machine_mode mode,
-                             int *punsignedp ATTRIBUTE_UNUSED,
+                             int *punsignedp,
                              const_tree fntype ATTRIBUTE_UNUSED,
                              int for_return ATTRIBUTE_UNUSED)
 {
-  if (POINTER_TYPE_P (type))
+  if (type != NULL_TREE && POINTER_TYPE_P (type))
     {
       *punsignedp = POINTERS_EXTEND_UNSIGNED;
       return Pmode;

diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi
index 7351e8338b888bf3ef8c9c1757e0f2f6679d6994..874a2237829f34572b06d3106bf52815035abb5a 100644 (file)
--- a/gcc/doc/tm.texi
+++ b/gcc/doc/tm.texi
@@ -962,6 +962,8 @@ which an incoming parameter is copied, or the outgoing result is computed;
 then the hook should return the same mode as @code{promote_mode}, though
 the signedness may be different.
 
+@var{type} can be NULL when promoting function arguments of libcalls.
+
 The default is to not promote arguments and return values.  You can
 also define the hook to @code{default_promote_function_mode_always_promote}
 if you would like to apply the same rules given by @code{PROMOTE_MODE}.

diff --git a/gcc/doc/tm.texi.in b/gcc/doc/tm.texi.in
index 45d5982eb7bb3d917c9b65ab993976202fe3c4d5..be84e4e84fa04b10f9734f77ceb74be2b90df408 100644 (file)
--- a/gcc/doc/tm.texi.in
+++ b/gcc/doc/tm.texi.in
@@ -952,6 +952,8 @@ which an incoming parameter is copied, or the outgoing result is computed;
 then the hook should return the same mode as @code{promote_mode}, though
 the signedness may be different.
 
+@var{type} can be NULL when promoting function arguments of libcalls.
+
 The default is to not promote arguments and return values.  You can
 also define the hook to @code{default_promote_function_mode_always_promote}
 if you would like to apply the same rules given by @code{PROMOTE_MODE}.

diff --git a/gcc/explow.c b/gcc/explow.c
index a0a160dd2bd2e721d8d607d3c97a3afa936aa5cf..da04505a7e8eb52924b16e46fc551715d5f4837d 100644 (file)
--- a/gcc/explow.c
+++ b/gcc/explow.c
@@ -771,6 +771,17 @@ enum machine_mode
 promote_function_mode (const_tree type, enum machine_mode mode, int *punsignedp,
                       const_tree funtype, int for_return)
 {
+  /* Called without a type node for a libcall.  */
+  if (type == NULL_TREE)
+    {
+      if (INTEGRAL_MODE_P (mode))
+       return targetm.calls.promote_function_mode (NULL_TREE, mode,
+                                                   punsignedp, funtype,
+                                                   for_return);
+      else
+       return mode;
+    }
+
   switch (TREE_CODE (type))
     {
     case INTEGER_TYPE:   case ENUMERAL_TYPE:   case BOOLEAN_TYPE:
@@ -791,6 +802,12 @@ enum machine_mode
 promote_mode (const_tree type ATTRIBUTE_UNUSED, enum machine_mode mode,
              int *punsignedp ATTRIBUTE_UNUSED)
 {
+  /* For libcalls this is invoked without TYPE from the backends
+     TARGET_PROMOTE_FUNCTION_MODE hooks.  Don't do anything in that
+     case.  */
+  if (type == NULL_TREE)
+    return mode;
+
   /* FIXME: this is the same logic that was there until GCC 4.4, but we
      probably want to test POINTERS_EXTEND_UNSIGNED even if PROMOTE_MODE
      is not defined.  The affected targets are M32C, S390, SPARC.  */

diff --git a/gcc/targhooks.c b/gcc/targhooks.c
index 93a2c305c8b80318833f236e5d83e05cbb1561dd..48d19a05416b0c86b28a66d60919f71c8c5286da 100644 (file)
--- a/gcc/targhooks.c
+++ b/gcc/targhooks.c
@@ -124,7 +124,7 @@ default_promote_function_mode (const_tree type ATTRIBUTE_UNUSED,
                               const_tree funtype ATTRIBUTE_UNUSED,
                               int for_return ATTRIBUTE_UNUSED)
 {
-  if (for_return == 2)
+  if (type != NULL_TREE && for_return == 2)
     return promote_mode (type, mode, punsignedp);
   return mode;
 }