2011-03-01 Michael Snyder <msnyder@vmware.com>

	* cli/cli-dump.c (restore_binary_file): Validate ftell return value.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9259a5ede413e4a28a72b9f306d86b9075491d70..53b05e939f86c72ba505335e559025ddf320721d 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,7 @@
 2011-03-01  Michael Snyder  <msnyder@vmware.com>
 
+       * cli/cli-dump.c (restore_binary_file): Validate ftell return value.
+
        * ada-lang.c (ada_make_symbol_completion_list): Replace malloc
        with xmalloc.
 

diff --git a/gdb/cli/cli-dump.c b/gdb/cli/cli-dump.c
index e288ee6860d2f262f7b89f55fe6f34534695cdd9..4bba10c35b84b52111a2349a8bc44882cf0174c3 100644 (file)
--- a/gdb/cli/cli-dump.c
+++ b/gdb/cli/cli-dump.c
@@ -511,7 +511,11 @@ restore_binary_file (char *filename, struct callback_data *data)
 
   /* Get the file size for reading.  */
   if (fseek (file, 0, SEEK_END) == 0)
-    len = ftell (file);
+    {
+      len = ftell (file);
+      if (len < 0)
+       perror_with_name (filename);
+    }
   else
     perror_with_name (filename);