midori: add missing BR2_TOOLCHAIN_USES_GLIBC dependency
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tue, 17 May 2016 21:39:57 +0000 (23:39 +0200)
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tue, 24 May 2016 15:08:59 +0000 (17:08 +0200)
midori selects webkitgtk, and webkitgtk needs a glibc toolchain, but
midori did not propagate this dependency, causing the following kconfig
warning:

warning: (BR2_PACKAGE_MIDORI) selects BR2_PACKAGE_WEBKITGTK which has unmet direct dependencies (BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 && BR2_TOOLCHAIN_USES_GLIBC && BR2_PACKAGE_LIBGTK3 && BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS)

Interestingly, the Config.in comment of the midori package already
mentionned the (e)glibc dependency, but the BR2_TOOLCHAIN_USES_GLIBC
dependency was not expressed (either on the comment or on the main
package option itself).

Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
package/midori/Config.in

index 91a63af2de6f44629fb4bfa8f8eb38a85da25990..9751f33eac99355ee71377e18560bd8f6aa9f962 100644 (file)
@@ -1,7 +1,7 @@
 comment "midori needs libgtk3 and an (e)glibc toolchain w/ C++, gcc >= 4.9"
        depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
        depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_LIBGTK3 \
-               || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+               || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_TOOLCHAIN_USES_GLIBC
 
 config BR2_PACKAGE_MIDORI
        bool "midori"
@@ -18,6 +18,7 @@ config BR2_PACKAGE_MIDORI
        depends on BR2_PACKAGE_LIBGTK3
        depends on BR2_INSTALL_LIBSTDCPP # webkitgtk
        depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # webkitgtk
+       depends on BR2_TOOLCHAIN_USES_GLIBC # webkitgtk
        depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
        help
          Midori is a lightweight web browser based on WebKit