re PR c++/54197 (Lifetime of reference not properly extended)

2012-08-31  Ollie Wild  <aaw@google.com>

	PR c++/54197
	* gcc/cp/call.c (extend_ref_init_temps_1): Handle COMPOUND_EXPR trees.
	* gcc/testsuite/g++.dg/init/lifetime3.C: New test.

From-SVN: r190834

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 0bfcde7ecd85cc93b07ec67929e920234f3aba88..5fb1b41c149162bd9b2cecc1c9a225d23217f609 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2012-08-31  Ollie Wild  <aaw@google.com>
+
+       PR c++/54197
+       * call.c (extend_ref_init_temps_1): Handle COMPOUND_EXPR trees.
+
 2012-08-30  Jason Merrill  <jason@redhat.com>
 
        PR c++/50545

diff --git a/gcc/cp/call.c b/gcc/cp/call.c
index 3915738e51629ea6381fce7acf9db9f91cd51a22..4d65b3e6dddeb0e86096ca5fbc275be16ed4ca86 100644 (file)
--- a/gcc/cp/call.c
+++ b/gcc/cp/call.c
@@ -8916,6 +8916,12 @@ extend_ref_init_temps_1 (tree decl, tree init, VEC(tree,gc) **cleanups)
   tree sub = init;
   tree *p;
   STRIP_NOPS (sub);
+  if (TREE_CODE (sub) == COMPOUND_EXPR)
+    {
+      TREE_OPERAND (sub, 1)
+        = extend_ref_init_temps_1 (decl, TREE_OPERAND (sub, 1), cleanups);
+      return init;
+    }
   if (TREE_CODE (sub) != ADDR_EXPR)
     return init;
   /* Deal with binding to a subobject.  */

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index b8d48f8d3714ed0c62150ec4fceeb7839e7a05c4..2d3bf4dd61f09eb49ee4bab555602b60ac374dc9 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2012-08-31  Ollie Wild  <aaw@google.com>
+
+       PR c++/54197
+       * g++.dg/init/lifetime3.C: New test.
+
 2012-08-31  Martin Jambor  <mjambor@suse.cz>
 
        PR middle-end/54409

diff --git a/gcc/testsuite/g++.dg/init/lifetime3.C b/gcc/testsuite/g++.dg/init/lifetime3.C
new file mode 100644 (file)
index 0000000..d099699
--- /dev/null
+++ b/gcc/testsuite/g++.dg/init/lifetime3.C
@@ -0,0 +1,37 @@
+// PR c++/26714
+// { dg-do run }
+
+extern "C" void abort();
+
+bool ok = false;
+struct A {
+  A() { }
+  ~A() { if (!ok) abort(); }
+};
+
+struct B {
+  static A foo() { return A(); }
+};
+
+B b_g;
+
+struct scoped_ptr {
+  B* operator->() const { return &b_g; }
+  B* get() const { return &b_g; }
+};
+
+B *get() { return &b_g; }
+
+int main()
+{
+  scoped_ptr f;
+  const A& ref1 = f->foo();
+  const A& ref2 = f.get()->foo();
+  const A& ref3 = get()->foo();
+  const A& ref4 = B::foo();
+  B *pf = f.get();
+  const A& ref5 = pf->foo();
+
+
+  ok = true;
+}