PR libstdc++/83226 avoid forming pointer-to-reference type

	PR libstdc++/83226
	* include/bits/node_handle.h (_Node_handle::__pointer): Avoid forming
	pointer-to-reference types.
	* testsuite/23_containers/map/modifiers/insert/83226.cc: New test.

From-SVN: r255271

diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index 55f194731af42f7080a640986248027fc126eaf0..a79a28488a356bced8016cb5361e3e4fedf59410 100644 (file)
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,3 +1,10 @@
+2017-11-30  Jonathan Wakely  <jwakely@redhat.com>
+
+       PR libstdc++/83226
+       * include/bits/node_handle.h (_Node_handle::__pointer): Avoid forming
+       pointer-to-reference types.
+       * testsuite/23_containers/map/modifiers/insert/83226.cc: New test.
+
 2017-11-29  John David Anglin  <danglin@gcc.gnu.org>
 
        * config/abi/post/hppa-linux-gnu/baseline_symbols.txt: Update.

diff --git a/libstdc++-v3/include/bits/node_handle.h b/libstdc++-v3/include/bits/node_handle.h
index 0d8dbeb411076c687c37b94facf0bb3902bb7730..7f109ada6f11b0e00d95846b287565b87bea9bfc 100644 (file)
--- a/libstdc++-v3/include/bits/node_handle.h
+++ b/libstdc++-v3/include/bits/node_handle.h
@@ -199,7 +199,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
       }
 
       template<typename _Tp>
-       using __pointer = __ptr_rebind<typename _AllocTraits::pointer, _Tp>;
+       using __pointer
+         = __ptr_rebind<typename _AllocTraits::pointer,
+                        remove_reference_t<_Tp>>;
 
       __pointer<_Key>                          _M_pkey = nullptr;
       __pointer<typename _Value::second_type>  _M_pmapped = nullptr;

diff --git a/libstdc++-v3/testsuite/23_containers/map/modifiers/insert/83226.cc b/libstdc++-v3/testsuite/23_containers/map/modifiers/insert/83226.cc
new file mode 100644 (file)
index 0000000..07afa5c
--- /dev/null
+++ b/libstdc++-v3/testsuite/23_containers/map/modifiers/insert/83226.cc
@@ -0,0 +1,30 @@
+// Copyright (C) 2017 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++17" }
+// { dg-do compile { target c++17 } }
+
+#include <map>
+
+void
+test01()
+{
+  int i = 0;
+  std::map<int, int&> m;
+  std::pair<const int, int&> p{1, i};
+  m.insert(p); // PR libstdc++/83226
+}