mem: Delete the packet accessors which use guest endianness.

These accessors create an extra dependency on the guest OS, and can be
avoided. Now that all their uses have been removed, they aren't needed
any more.

Change-Id: I466c07fef99bce2d7964c07a7ac3dd398691378b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/13465
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>

diff --git a/src/mem/packet.hh b/src/mem/packet.hh
index 407172f9893fd65ad4697b9beda1990a9d4e942e..4aee81f9ba33dd712260bdfef887b55dcf5d84d1 100644 (file)
--- a/src/mem/packet.hh
+++ b/src/mem/packet.hh
@@ -64,7 +64,6 @@
 #include "base/logging.hh"
 #include "base/printable.hh"
 #include "base/types.hh"
-#include "config/the_isa.hh"
 #include "mem/request.hh"
 #include "sim/core.hh"
 
@@ -1124,16 +1123,6 @@ class Packet : public Printable
     template <typename T>
     T get(ByteOrder endian) const;
 
-#if THE_ISA != NULL_ISA
-    /**
-     * Get the data in the packet byte swapped from guest to host
-     * endian.
-     */
-    template <typename T>
-    T get() const
-        M5_DEPRECATED_MSG("The memory system should be ISA independent.");
-#endif
-
     /** Set the value in the data pointer to v as big endian. */
     template <typename T>
     void setBE(T v);
@@ -1149,13 +1138,6 @@ class Packet : public Printable
     template <typename T>
     void set(T v, ByteOrder endian);
 
-#if THE_ISA != NULL_ISA
-    /** Set the value in the data pointer to v as guest endian. */
-    template <typename T>
-    void set(T v)
-        M5_DEPRECATED_MSG("The memory system should be ISA independent.");
-#endif
-
     /**
      * Get the data in the packet byte swapped from the specified
      * endianness and zero-extended to 64 bits.

diff --git a/src/mem/packet_access.hh b/src/mem/packet_access.hh
index 97357ae5e355406902c1d5fc0af1658f2ebe4185..06c1068eb84fd23a2b62b6de8a69223d300e1785 100644 (file)
--- a/src/mem/packet_access.hh
+++ b/src/mem/packet_access.hh
@@ -42,13 +42,12 @@
  *          Andreas Sandberg
  */
 
-#include "arch/isa_traits.hh"
-#include "mem/packet.hh"
-#include "sim/byteswap.hh"
-
 #ifndef __MEM_PACKET_ACCESS_HH__
 #define __MEM_PACKET_ACCESS_HH__
 
+#include "mem/packet.hh"
+#include "sim/byteswap.hh"
+
 template <typename T>
 inline T
 Packet::getRaw() const
@@ -98,15 +97,6 @@ Packet::get(ByteOrder endian) const
     };
 }
 
-#if THE_ISA != NULL_ISA
-template <typename T>
-inline T
-Packet::get() const
-{
-    return TheISA::gtoh(getRaw<T>());
-}
-#endif
-
 template <typename T>
 inline void
 Packet::setBE(T v)
@@ -137,13 +127,4 @@ Packet::set(T v, ByteOrder endian)
     };
 }
 
-#if THE_ISA != NULL_ISA
-template <typename T>
-inline void
-Packet::set(T v)
-{
-    setRaw(TheISA::htog(v));
-}
-#endif
-
 #endif //__MEM_PACKET_ACCESS_HH__