2000-04-27 H.J. Lu <hjl@gnu.org>

	* elf.c (_bfd_elf_link_hash_hide_symbol): Set dynindx to -1
	only for ELF_LINK_FORCED_LOCAL.
	* elf32-hppa.c (elf32_hppa_hide_symbol): Likewise.
	* elf32-mips.c (_bfd_mips_elf_hide_symbol): Likewise.
	* elfxx-ia64.c (elfNN_ia64_hash_hide_symbol): Likewise.

	* elflink.h (elf_fix_symbol_flags): Set ELF_LINK_FORCED_LOCAL
	if the symbol has hidden or internal visibility.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index eebb8fa1905fee669fa2fd17ed5e7f90ba6c9c19..8e6ab54b0cdbb7c84dc12f0167e9511824629e56 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,14 @@
+2001-04-30  H.J. Lu  <hjl@gnu.org>
+
+       * elf.c (_bfd_elf_link_hash_hide_symbol): Set dynindx to -1
+       only for ELF_LINK_FORCED_LOCAL.
+       * elf32-hppa.c (elf32_hppa_hide_symbol): Likewise.
+       * elf32-mips.c (_bfd_mips_elf_hide_symbol): Likewise.
+       * elfxx-ia64.c (elfNN_ia64_hash_hide_symbol): Likewise.
+
+       * elflink.h (elf_fix_symbol_flags): Set ELF_LINK_FORCED_LOCAL
+       if the symbol has hidden or internal visibility.
+
 2001-04-30  Alan Modra  <amodra@one.net.au>
 
        * elf32-hppa.c (final_link_relocate): Branch to .+8 for

diff --git a/bfd/elf.c b/bfd/elf.c
index 26ce9d3b0a7ff743d0914ed306e469cdf5247486..602ebcdfcee2313f1155f2e230659e4655125d58 100644 (file)
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -1014,8 +1014,9 @@ _bfd_elf_link_hash_hide_symbol (info, h)
      struct elf_link_hash_entry *h;
 {
   h->elf_link_hash_flags &= ~ELF_LINK_HASH_NEEDS_PLT;
-  h->dynindx = -1;
   h->plt.offset = (bfd_vma) -1;
+  if ((h->elf_link_hash_flags & ELF_LINK_FORCED_LOCAL) != 0)
+    h->dynindx = -1;
 }
 
 /* Initialize an ELF linker hash table.  */

diff --git a/bfd/elf32-hppa.c b/bfd/elf32-hppa.c
index fdcb3b4ff7e004833c7c488581d95366dcf71ba3..02242154529ed0fd09cfb03d23727258fe5dc47a 100644 (file)
--- a/bfd/elf32-hppa.c
+++ b/bfd/elf32-hppa.c
@@ -1863,7 +1863,8 @@ elf32_hppa_hide_symbol (info, h)
      struct bfd_link_info *info ATTRIBUTE_UNUSED;
      struct elf_link_hash_entry *h;
 {
-  h->dynindx = -1;
+  if ((h->elf_link_hash_flags & ELF_LINK_FORCED_LOCAL) != 0)
+    h->dynindx = -1;
   if (! ((struct elf32_hppa_link_hash_entry *) h)->plabel)
     {
       h->elf_link_hash_flags &= ~ELF_LINK_HASH_NEEDS_PLT;

diff --git a/bfd/elf32-mips.c b/bfd/elf32-mips.c
index efbcbfab293e3b2ea4f9835a0f1c72e9eed37c9c..065e7d786486d705d3a15061e1ea30375b82a849 100644 (file)
--- a/bfd/elf32-mips.c
+++ b/bfd/elf32-mips.c
@@ -4002,7 +4002,8 @@ _bfd_mips_elf_hide_symbol (info, h)
 
   h->root.elf_link_hash_flags &= ~ELF_LINK_HASH_NEEDS_PLT;
   h->root.plt.offset = (bfd_vma) -1;
-  h->root.dynindx = -1;
+  if ((h->root.elf_link_hash_flags & ELF_LINK_FORCED_LOCAL) != 0)
+    h->root.dynindx = -1;
 
   /* FIXME: Do we allocate too much GOT space here?  */
   g->local_gotno++;

diff --git a/bfd/elflink.h b/bfd/elflink.h
index d175223ffa97ae3c07421496459c740d83a929c4..4973ae36f21100718c11d293cdf2fb202db61ca5 100644 (file)
--- a/bfd/elflink.h
+++ b/bfd/elflink.h
@@ -3541,6 +3541,9 @@ elf_fix_symbol_flags (h, eif)
     {
       struct elf_backend_data *bed;
       bed = get_elf_backend_data (elf_hash_table (eif->info)->dynobj);
+      if (ELF_ST_VISIBILITY (h->other) == STV_INTERNAL
+         || ELF_ST_VISIBILITY (h->other) == STV_HIDDEN)
+       h->elf_link_hash_flags |= ELF_LINK_FORCED_LOCAL;
       (*bed->elf_backend_hide_symbol) (eif->info, h);
     }
 

diff --git a/bfd/elfxx-ia64.c b/bfd/elfxx-ia64.c
index 77d20221d9a646043d4d14f7e7fa0f6cdc938c3f..8d80e6e27dfc9725510e9043e51e60705f591fda 100644 (file)
--- a/bfd/elfxx-ia64.c
+++ b/bfd/elfxx-ia64.c
@@ -1524,7 +1524,8 @@ elfNN_ia64_hash_hide_symbol (info, xh)
   h = (struct elfNN_ia64_link_hash_entry *)xh;
 
   h->root.elf_link_hash_flags &= ~ELF_LINK_HASH_NEEDS_PLT;
-  h->root.dynindx = -1;
+  if ((h->root.elf_link_hash_flags & ELF_LINK_FORCED_LOCAL) != 0)
+    h->root.dynindx = -1;
 
   for (dyn_i = h->info; dyn_i; dyn_i = dyn_i->next)
     dyn_i->want_plt2 = 0;