* coff-arm.c (coff_arm_is_local_label_name): Warning fix.

	* elf32-frv.c (frvfdpic_relocs_info_hash): Likewise.
	* pef.c (bfd_pef_scan): Don't ignore return value of
	bfd_pef_scan_start_address.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 21dd79f9ede0eb8143a7b330e2a862792c7e25fe..b0633b96b0b6095ac602da5151980b849af2bcb4 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@
+2005-02-16  Alan Modra  <amodra@bigpond.net.au>
+
+       * coff-arm.c (coff_arm_is_local_label_name): Warning fix.
+       * elf32-frv.c (frvfdpic_relocs_info_hash): Likewise.
+       * pef.c (bfd_pef_scan): Don't ignore return value of
+       bfd_pef_scan_start_address.
+
 2005-02-16  Alan Modra  <amodra@bigpond.net.au>
 
        * elf64-ppc.c (ppc64_elf_edit_toc): Skip toc if size is zero.

diff --git a/bfd/coff-arm.c b/bfd/coff-arm.c
index c6580a81a4b0395157206c9551db7d9c9e6aa213..c336285ef11bece92659805c40ba141620712f86 100644 (file)
--- a/bfd/coff-arm.c
+++ b/bfd/coff-arm.c
@@ -1,6 +1,6 @@
 /* BFD back-end for ARM COFF files.
    Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
-   2000, 2001, 2002, 2003, 2004
+   2000, 2001, 2002, 2003, 2004, 2005
    Free Software Foundation, Inc.
    Written by Cygnus Support.
 
@@ -2504,7 +2504,9 @@ coff_arm_is_local_label_name (abfd, name)
 #ifdef USER_LABEL_PREFIX
   if (USER_LABEL_PREFIX[0] != 0)
     {
-      if (strncmp (name, USER_LABEL_PREFIX, strlen (USER_LABEL_PREFIX)) == 0)
+      size_t len = strlen (USER_LABEL_PREFIX);
+
+      if (strncmp (name, USER_LABEL_PREFIX, len) == 0)
        return FALSE;
     }
 #endif

diff --git a/bfd/elf32-frv.c b/bfd/elf32-frv.c
index 009507a074c632e6b1a019ca519025ddd6aab386..15f469e2849a8f5d148a4a24f9426e1551d79df9 100644 (file)
--- a/bfd/elf32-frv.c
+++ b/bfd/elf32-frv.c
@@ -1144,8 +1144,8 @@ frvfdpic_relocs_info_hash (const void *entry_)
   const struct frvfdpic_relocs_info *entry = entry_;
 
   return (entry->symndx == -1
-         ? (long)entry->d.h->root.root.hash
-         : entry->symndx + entry->d.abfd->id * 257) + entry->addend;
+         ? (long) entry->d.h->root.root.hash
+         : entry->symndx + (long) entry->d.abfd->id * 257) + entry->addend;
 }
 
 /* Test whether the key fields of two frvfdpic_relocs_info entries are

diff --git a/bfd/pef.c b/bfd/pef.c
index 7f266c5cff9f5664e2d4b3a95094ce00742d7fab..22d302f319690784c0ce1af155863206f804986b 100644 (file)
--- a/bfd/pef.c
+++ b/bfd/pef.c
@@ -1,5 +1,5 @@
 /* PEF support for BFD.
-   Copyright 1999, 2000, 2001, 2002, 2003, 2004
+   Copyright 1999, 2000, 2001, 2002, 2003, 2004, 2005
    Free Software Foundation, Inc.
 
    This file is part of BFD, the Binary File Descriptor library.
@@ -600,7 +600,7 @@ bfd_pef_scan (abfd, header, mdata)
     }
 
   if (bfd_pef_scan_start_address (abfd) < 0)
-    ;
+    return -1;
 
   abfd->tdata.pef_data = mdata;