r300g: Really destroy translated buffer at the end.
authorŁukasz Krotowski <lukasz.krotowski@gmail.com>
Thu, 14 Jan 2010 09:05:02 +0000 (10:05 +0100)
committerCorbin Simpson <MostAwesomeDude@gmail.com>
Thu, 14 Jan 2010 17:01:37 +0000 (09:01 -0800)
Note that indexSize is changed by r300_translate_elts(). Also make sure
it's destroyed on errors.

src/gallium/drivers/r300/r300_render.c

index 6645688fc58abf5e91bc965ed4f2f70e7be43c5f..528741ab7c06650bb30a72971c0c724d59791477 100644 (file)
@@ -316,6 +316,7 @@ void r300_draw_range_elements(struct pipe_context* pipe,
         return;
     }
 
+       struct pipe_buffer* orgIndexBuffer = indexBuffer;
     if (indexSize == 1) {
         indexBuffer = r300_translate_elts(r300, indexBuffer,
             &indexSize, &mode, &count);
@@ -323,11 +324,11 @@ void r300_draw_range_elements(struct pipe_context* pipe,
 
     if (!r300->winsys->add_buffer(r300->winsys, indexBuffer,
                                   RADEON_GEM_DOMAIN_GTT, 0)) {
-        return;
+        goto cleanup;
     }
 
     if (!r300->winsys->validate(r300->winsys)) {
-        return;
+        goto cleanup;
     }
 
     r300_emit_dirty_state(r300);
@@ -337,7 +338,8 @@ void r300_draw_range_elements(struct pipe_context* pipe,
     r300_emit_draw_elements(r300, indexBuffer, indexSize, minIndex, maxIndex,
                             mode, start, count);
 
-    if (indexSize == 1) {
+cleanup:
+    if (indexBuffer != orgIndexBuffer) {
         pipe->screen->buffer_destroy(indexBuffer);
     }
 }