radv: do not update the number of viewports in vkCmdSetViewport()
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Mon, 18 Sep 2017 09:45:55 +0000 (11:45 +0200)
committerSamuel Pitoiset <samuel.pitoiset@gmail.com>
Wed, 20 Sep 2017 08:27:32 +0000 (10:27 +0200)
The Vulkan spec (1.0.61) says:

   "The number of viewports used by a pipeline is still specified
   by the viewportCount member of VkPipelineViewportStateCreateInfo."

So, the number of viewports is defined at pipeline creation
time and shouldn't be updated when they are set dynamically.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
src/amd/vulkan/radv_cmd_buffer.c

index d7b27cae27c3bf184f76447f61e3b23009e8d500..9724cc52940b6ccda88b7dc556acc5db87887de0 100644 (file)
@@ -2502,9 +2502,6 @@ void radv_CmdSetViewport(
        assert(firstViewport < MAX_VIEWPORTS);
        assert(total_count >= 1 && total_count <= MAX_VIEWPORTS);
 
-       if (cmd_buffer->state.dynamic.viewport.count < total_count)
-               cmd_buffer->state.dynamic.viewport.count = total_count;
-
        memcpy(cmd_buffer->state.dynamic.viewport.viewports + firstViewport,
               pViewports, viewportCount * sizeof(*pViewports));