base: Add a static assert to check bit union ranges

If a bit field in a bit union specified as Bitfield<LSB, MSB> instead
of Bitfield<MSB, LSB> the code silently fails and the field is read as
zero. This changeset introduces a static assert that tests, at compile
time, that the bit order is correct.

diff --git a/src/base/bitunion.hh b/src/base/bitunion.hh
index f640fa3b19275b3d77400037312bc5453cdf870f..190c1a5e13d6dfa74617013a48e301087ea83a0f 100644 (file)
--- a/src/base/bitunion.hh
+++ b/src/base/bitunion.hh
@@ -85,6 +85,9 @@ namespace BitfieldBackend
         template<int first, int last=first>
         class Bitfield : public BitfieldBase<Type>
         {
+            static_assert(first >= last,
+                          "Bitfield ranges must be specified as <msb, lsb>");
+
           public:
             operator const uint64_t () const
             {