egl/android: add a note about .swap_buffers_with_damage
authorEmil Velikov <emil.velikov@collabora.com>
Mon, 16 Oct 2017 16:10:42 +0000 (17:10 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Wed, 8 Nov 2017 14:42:12 +0000 (14:42 +0000)
Android implements the API and does the native damage handling itself.
At the same time it
 a) does call the vendor's eglSwapBuffersWithDamageKHR
 b) does not implement eglSetDamageRegionKHR

There's something strange happening here. For now simply note about the
'lack' of eglSwapBuffersWithDamageKHR support.

Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
src/egl/drivers/dri2/platform_android.c

index e390365b8bbfb9ec13a7549cc8137ccb20668952..63223e9a69fe41f3361aa3ec8921d28da2ce33e2 100644 (file)
@@ -1088,7 +1088,7 @@ static const struct dri2_egl_display_vtbl droid_display_vtbl = {
    .destroy_surface = droid_destroy_surface,
    .create_image = droid_create_image_khr,
    .swap_buffers = droid_swap_buffers,
-   .swap_buffers_with_damage = dri2_fallback_swap_buffers_with_damage,
+   .swap_buffers_with_damage = dri2_fallback_swap_buffers_with_damage, /* Android implements the function */
    .swap_buffers_region = dri2_fallback_swap_buffers_region,
 #if ANDROID_API_LEVEL >= 23
    .set_damage_region = droid_set_damage_region,