[libcody] Remove some std::move [PR 98368]

Compiling on clang showed a couple of pessimizations.  Fixed thusly.

	libcody/
	* client.cc (Client::ProcessResponse): Remove std::move
	inside ?:
	c++tools/
	* resolver.cc (module_resolver::cmi_response): Remove
	std::move of temporary.

diff --git a/c++tools/resolver.cc b/c++tools/resolver.cc
index c8d3115357428d9d2815ae690377f7c7e5128a2e..ef08de530721aeffc1fc605b51ed2b69e6202e95 100644 (file)
--- a/c++tools/resolver.cc
+++ b/c++tools/resolver.cc
@@ -226,9 +226,7 @@ module_resolver::cmi_response (Cody::Server *s, std::string &module)
   auto iter = map.find (module);
   if (iter == map.end ())
     {
-      std::string file;
-      if (default_map)
-       file = std::move (GetCMIName (module));
+      std::string file = default_map ? GetCMIName (module) : std::string ();
       auto res = map.emplace (module, file);
       iter = res.first;
     }

diff --git a/libcody/client.cc b/libcody/client.cc
index edfe44d34b2562b872e36ae6f8576a175592f44e..ae69d190cb77fca26550c141a99cf45c78ac0045 100644 (file)
--- a/libcody/client.cc
+++ b/libcody/client.cc
@@ -122,8 +122,7 @@ Packet Client::ProcessResponse (std::vector<std::string> &words,
   Assert (!words.empty ());
   if (words[0] == u8"ERROR")
     return Packet (Client::PC_ERROR,
-                 std::move (words.size () == 2 ? words[1]
-                            : u8"malformed error response"));
+                  words.size () == 2 ? words[1]: u8"malformed error response");
 
   if (isLast && !read.IsAtEnd ())
     return Packet (Client::PC_ERROR,