insndb/db: change naming a bit
authorDmitry Selyutin <ghostmansd@gmail.com>
Sun, 4 Jun 2023 08:53:10 +0000 (11:53 +0300)
committerLuke Kenneth Casson Leighton <lkcl@lkcl.net>
Fri, 22 Dec 2023 19:26:19 +0000 (19:26 +0000)
src/openpower/insndb/db.py

index b8311f31780262e767601374b5332484db26a57f..3b79a1807e311136edefb86bb7090794255efb45 100644 (file)
@@ -38,29 +38,29 @@ class ListVisitor(BaseVisitor):
         yield record
 
 
-class ConcreteInstructionVisitor(BaseVisitor):
+class InstructionVisitor(BaseVisitor):
     def __init__(self, insn, **_):
         self.__insn = insn
         return super().__init__()
 
-    def handler(self, record):
+    def concrete_record(self, record):
         raise NotImplementedError
 
     @contextlib.contextmanager
     def record(self, record):
         if record.name == self.__insn:
-            self.handler(record=record)
+            self.concrete_record(record=record)
         yield record
 
 
-class OpcodesVisitor(ConcreteInstructionVisitor):
-    def handler(self, record):
+class OpcodesVisitor(InstructionVisitor):
+    def concrete_record(self, record):
         for opcode in record.opcodes:
             print(opcode)
 
 
-class OperandsVisitor(ConcreteInstructionVisitor):
-    def handler(self, record):
+class OperandsVisitor(InstructionVisitor):
+    def concrete_record(self, record):
         for operand in record.dynamic_operands:
             print(operand.name)
         for operand in record.static_operands:
@@ -68,8 +68,8 @@ class OperandsVisitor(ConcreteInstructionVisitor):
                 print(operand.name, operand.value, sep="=")
 
 
-class PCodeVisitor(ConcreteInstructionVisitor):
-    def handler(self, record):
+class PCodeVisitor(InstructionVisitor):
+    def concrete_record(self, record):
         for line in record.pcode:
             print(line)
 
@@ -103,7 +103,7 @@ def main():
 
     for (command, (visitor, help)) in commands.items():
         parser = main_subparser.add_parser(command, help=help)
-        if issubclass(visitor, ConcreteInstructionVisitor):
+        if issubclass(visitor, InstructionVisitor):
             parser.add_argument("insn", type=Instruction,
                 metavar="INSN", help="instruction")