d: Fix ICE in uda_attribute_p when looking up unknown attribute
authorIain Buclaw <ibuclaw@gdcproject.org>
Tue, 23 Jun 2020 14:25:29 +0000 (16:25 +0200)
committerIain Buclaw <ibuclaw@gdcproject.org>
Thu, 25 Jun 2020 15:02:45 +0000 (17:02 +0200)
The target attribute table is not guaranteed to be set in all backends.

gcc/d/ChangeLog:

PR d/95173
* d-attribs.cc (uda_attribute_p): Don't search target attribute table
if NULL.

gcc/testsuite/ChangeLog:

PR d/95173
* gdc.dg/pr95173.d: New test.

gcc/d/d-attribs.cc
gcc/testsuite/gdc.dg/pr95173.d [new file with mode: 0644]

index 964f59f96f4c7f4cf25635039cdb9eadaa0c81f4..f4086c0f0ee090400a46192eb2f9c0b136cd4bb0 100644 (file)
@@ -216,10 +216,13 @@ uda_attribute_p (const char *name)
        return true;
     }
 
-  for (const attribute_spec *p = targetm.attribute_table; p->name; p++)
+  if (targetm.attribute_table)
     {
-      if (get_identifier (p->name) == ident)
-       return true;
+      for (const attribute_spec *p = targetm.attribute_table; p->name; p++)
+       {
+         if (get_identifier (p->name) == ident)
+           return true;
+       }
     }
 
   return false;
diff --git a/gcc/testsuite/gdc.dg/pr95173.d b/gcc/testsuite/gdc.dg/pr95173.d
new file mode 100644 (file)
index 0000000..2a4b2ed
--- /dev/null
@@ -0,0 +1,10 @@
+// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95173
+// { dg-do compile }
+// { dg-options "-Wattributes" }
+
+import gcc.attribute;
+
+@attribute("foo") // { dg-warning "unknown attribute .foo." }
+void f95173() 
+{
+}