Garbage collect py-utils.c:target_string_to_unicode.

The strlen in this function looked suspicious, for the function
documents that STR is in the target's charset (what if it is utf-32,
etc.).

On closer inspection, nothing is calling the function, and it's been
that way ever since the function was added.

gdb/
2013-03-06  Pedro Alves  <palves@redhat.com>

	* python/py-utils.c (target_string_to_unicode): Delete function.
	* python/python-internal.h (target_string_to_unicode): Delete
	declaration.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9857be4dbb2e675f00e6064caa98275014593036..26c50a2ed5bf722425253e048250d7edec040f2e 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2013-03-06  Pedro Alves  <palves@redhat.com>
+
+       * python/py-utils.c (target_string_to_unicode): Delete function.
+       * python/python-internal.h (target_string_to_unicode): Delete
+       declaration.
+
 2013-03-06  Pierre Muller  <muller@sourceware.org>
 
        * linespec.c (get_current_search_block): ARI fix, use (void)

diff --git a/gdb/python/py-utils.c b/gdb/python/py-utils.c
index a3ae61fe029a4d5a303c834987bf2d3165f90c2c..b280c8cc716ceb14158de3b9c2ce4ccfbe898f13 100644 (file)
--- a/gdb/python/py-utils.c
+++ b/gdb/python/py-utils.c
@@ -204,19 +204,6 @@ python_string_to_host_string (PyObject *obj)
   return result;
 }
 
-/* Converts a target string of LENGTH bytes in the target's charset to a
-   Python Unicode string. If LENGTH is -1, convert until a null byte is found.
-
-   Returns NULL on error, with a python exception set.  */
-PyObject *
-target_string_to_unicode (const gdb_byte *str, int length)
-{
-  if (length == -1)
-    length = strlen (str);
-
-  return PyUnicode_Decode (str, length, target_charset (python_gdbarch), NULL);
-}
-
 /* Return true if OBJ is a Python string or unicode object, false
    otherwise.  */
 

diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h
index 8dff1d76386561ff546f18fa1449f4b56cdc1daa..753ba96a012e88c93f66c9c4d53e5235f5dcf3ea 100644 (file)
--- a/gdb/python/python-internal.h
+++ b/gdb/python/python-internal.h
@@ -335,7 +335,6 @@ char *unicode_to_target_string (PyObject *unicode_str);
 char *python_string_to_target_string (PyObject *obj);
 PyObject *python_string_to_target_python_string (PyObject *obj);
 char *python_string_to_host_string (PyObject *obj);
-PyObject *target_string_to_unicode (const gdb_byte *str, int length);
 int gdbpy_is_string (PyObject *obj);
 char *gdbpy_obj_to_string (PyObject *obj);
 char *gdbpy_exception_to_string (PyObject *ptype, PyObject *pvalue);