ld: ld-lib.exp: log failed dump.out contents for debugging
authorSam James <sam@gentoo.org>
Wed, 16 Aug 2023 06:21:53 +0000 (07:21 +0100)
committerSam James <sam@gentoo.org>
Thu, 17 Aug 2023 04:21:02 +0000 (05:21 +0100)
If we're using dump_prog in a test which fails, log the dump.out contents
to ld.log to aid debugging.

This avoids needing to ask reporters to manually run e.g. `objdump` commands
when making bug reports.

PR30722
* ld/testsuite/lib/ld-lib.exp: Log failed dump.out contents to aid
debugging.

Approved-by: Nick Clifton <nickc@redhat.com>
Signed-off-by: Sam James <sam@gentoo.org>
ld/testsuite/lib/ld-lib.exp

index 918464069a96157f5996695b6f5db212742b5751..aca303e0728a749362cfbb81dd1f82ca1fa0d460 100644 (file)
@@ -640,7 +640,7 @@ proc run_ld_link_tests { ldtests args } {
                    remote_upload host "dump.out"
 
                    if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then {
-                       verbose "output is [file_contents "dump.out"]" 2
+                       verbose -log "output is [file_contents "dump.out"]" 2
                        set failed 1
                        remote_file build delete "dump.out"
                        remote_file host delete "dump.out"
@@ -1067,7 +1067,7 @@ proc run_cc_link_tests { ldtests } {
                    }
 
                    if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then {
-                       verbose "output is [file_contents "dump.out"]" 2
+                       verbose -log "output is [file_contents "dump.out"]" 2
                        set failed 1
                        break
                    }