Don't rely on inferior I/O in gdb.base/siginfo-addr.exp
authorPedro Alves <palves@redhat.com>
Wed, 29 Jul 2015 10:09:36 +0000 (11:09 +0100)
committerPedro Alves <palves@redhat.com>
Wed, 29 Jul 2015 10:09:36 +0000 (11:09 +0100)
No point in relying on stdio in this test.  Simply run to a breakpoint
instead.

gdb/testsuite/ChangeLog:
2015-07-29  Pedro Alves  <palves@redhat.com>

* gdb.base/siginfo-addr.c (pass): New function.
(handler): Call it iff si_addr is correct.
* gdb.base/siginfo-addr.exp: Remove gdb_skip_stdio_test check.
Set a breakpoint at "pass" and continue to it.

gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/siginfo-addr.c
gdb/testsuite/gdb.base/siginfo-addr.exp

index 34f6d8b70f7a0bb5240b9467f9fb34120fc45bff..9f36af6d09bfd9c5cf869bb66de6bd3880dc6fda 100644 (file)
@@ -1,3 +1,10 @@
+2015-07-29  Pedro Alves  <palves@redhat.com>
+
+       * gdb.base/siginfo-addr.c (pass): New function.
+       (handler): Call it iff si_addr is correct.
+       * gdb.base/siginfo-addr.exp: Remove gdb_skip_stdio_test check.
+       Set a breakpoint at "pass" and continue to it.
+
 2015-07-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 
        * gdb.python/py-objfile.exp: Make some tests have unique names.
index a074b4d620fc0a81659f61c1535d74ab8da29697..c6d85562da73f15054a667dbb16f0ed7d78fba72 100644 (file)
 
 static void *p;
 
+void
+pass (void)
+{
+}
+
 static void
 handler (int sig, siginfo_t *info, void *context)
 {
   if (info->si_addr == p)
-    printf ("Correct si_addr value.\n");
-  else
-    printf ("Got si_addr = %p, expected %p.\n", info->si_addr, p);
+    pass ();
   _exit (0);
 }
 
index 5ac61050819c24f42f4b562eaf045a884acd41d5..e2f591414f36d7061c86053e82dc910974bc2b38 100644 (file)
@@ -26,11 +26,6 @@ if [target_info exists gdb,nosignals] {
     continue
 }
 
-if [gdb_skip_stdio_test "siginfo-addr.exp"] {
-    continue
-}
-
-
 standard_testfile
 if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
     untested "Couldn't compile ${srcfile}.c"
@@ -47,13 +42,7 @@ if { ![runto_main] } then {
 # Run to the signal.
 gdb_test "continue" ".*Program received signal SIGSEGV.*" "continue to signal"
 
+gdb_breakpoint "pass"
+
 # Check for correct si_addr.
-set test "program exit"
-gdb_test_multiple "continue" "${test}" {
-    -re "Correct si_addr" {
-       pass "si_addr value"
-    }
-    -re "Got si_addr" {
-       fail "si_addr value"
-    }
-}
+gdb_test "continue" "Breakpoint .* pass .*" "correct si_addr"