PE fake section for C_SECTION syms
authorAlan Modra <amodra@gmail.com>
Tue, 21 Mar 2023 22:32:57 +0000 (09:02 +1030)
committerAlan Modra <amodra@gmail.com>
Tue, 21 Mar 2023 22:32:57 +0000 (09:02 +1030)
It's an odd thing to have objdump -x show a different section table
to objdump -h, but that can happen if swapping in symbols leads to
creating sections.  Setting SEC_LINKER_CREATED stops the display of
these sections, so that you get shown what is in the object file.

* peXXigen.c (_bfd_XXi_swap_sym_in): Set SEC_LINKER_CREATED on
fake section created for C_SECTION syms.  Don't zero asection
fields that are already zero.

bfd/peXXigen.c

index d59a97f0d1110fa3af686f61add4ef6de0f86e79..42f2d21cee390c794939894cf54bc1397a1489d0 100644 (file)
@@ -189,7 +189,8 @@ _bfd_XXi_swap_sym_in (bfd * abfd, void * ext1, void * in1)
            }
          memcpy (sec_name, name, name_len);
 
-         flags = SEC_HAS_CONTENTS | SEC_ALLOC | SEC_DATA | SEC_LOAD;
+         flags = (SEC_HAS_CONTENTS | SEC_ALLOC | SEC_DATA | SEC_LOAD
+                  | SEC_LINKER_CREATED);
          sec = bfd_make_section_anyway_with_flags (abfd, sec_name, flags);
          if (sec == NULL)
            {
@@ -198,18 +199,7 @@ _bfd_XXi_swap_sym_in (bfd * abfd, void * ext1, void * in1)
              return;
            }
 
-         sec->vma = 0;
-         sec->lma = 0;
-         sec->size = 0;
-         sec->filepos = 0;
-         sec->rel_filepos = 0;
-         sec->reloc_count = 0;
-         sec->line_filepos = 0;
-         sec->lineno_count = 0;
-         sec->userdata = NULL;
-         sec->next = NULL;
          sec->alignment_power = 2;
-
          sec->target_index = unused_section_number;
 
          in->n_scnum = unused_section_number;