intel/eu: Assert that the instruction is send-like in brw_set_desc_ex().
authorFrancisco Jerez <currojerez@riseup.net>
Sun, 3 Jun 2018 20:20:45 +0000 (13:20 -0700)
committerFrancisco Jerez <currojerez@riseup.net>
Tue, 10 Jul 2018 06:46:58 +0000 (23:46 -0700)
Constructing a descriptor in-place as part of the immediate of an ALU
instruction is no longer supported.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/intel/compiler/brw_eu_emit.c

index 2346d1a966caf6356690fd7b2e457653faed9cfe..0847d9b404cdd5496dd54fe0ec1df3607cd70de4 100644 (file)
@@ -368,11 +368,12 @@ brw_set_desc_ex(struct brw_codegen *p, brw_inst *inst,
                 unsigned desc, unsigned ex_desc)
 {
    const struct gen_device_info *devinfo = p->devinfo;
+   assert(brw_inst_opcode(devinfo, inst) == BRW_OPCODE_SEND ||
+          brw_inst_opcode(devinfo, inst) == BRW_OPCODE_SENDC);
    brw_inst_set_src1_file_type(devinfo, inst,
                                BRW_IMMEDIATE_VALUE, BRW_REGISTER_TYPE_D);
    brw_inst_set_send_desc(devinfo, inst, desc);
-   if (devinfo->gen >= 9 && (brw_inst_opcode(devinfo, inst) == BRW_OPCODE_SEND ||
-                             brw_inst_opcode(devinfo, inst) == BRW_OPCODE_SENDC))
+   if (devinfo->gen >= 9)
       brw_inst_set_send_ex_desc(devinfo, inst, ex_desc);
 }