ruby: improved isReadWrite fix me comment
authorBrad Beckmann <Brad.Beckmann@amd.com>
Mon, 22 Mar 2010 18:19:17 +0000 (11:19 -0700)
committerBrad Beckmann <Brad.Beckmann@amd.com>
Mon, 22 Mar 2010 18:19:17 +0000 (11:19 -0700)
src/mem/ruby/system/RubyPort.cc

index 314f551d1d2b44ea32b7edfb377234efe46adf6a..480c13ad8a518a6907aa30e1694c7a36dce43c52 100644 (file)
@@ -230,8 +230,10 @@ RubyPort::M5Port::recvTiming(PacketPtr pkt)
             type = RubyRequestType_ST;
         } else if (pkt->isReadWrite()) {
             //
-            // Fix me. Just because the packet is a read/write request does not
-            // necessary mean it is a read-modify-write atomic operation.
+            // Fix me.  This conditional will never be executed because 
+            // isReadWrite() is just an OR of isRead() and isWrite().  
+            // Furthermore, just because the packet is a read/write request does
+            // not necessary mean it is a read-modify-write atomic operation.
             //
             type = RubyRequestType_RMW_Write;
         } else {