sim/erc32: Add ATTRIBUTE_PRINTF

Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral").  On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).

To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.

This commit adds ATTRIBUTE_PRINTF to the printf-like functions.

diff --git a/sim/erc32/interf.c b/sim/erc32/interf.c
index f433b9d55ac3c86090777a2e6cfbbf18aa1de6ab..aa3ffdc7ada11f7c1ec6358b21998f7178ee63e8 100644 (file)
--- a/sim/erc32/interf.c
+++ b/sim/erc32/interf.c
@@ -156,7 +156,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis)
     return TIME_OUT;
 }
 
-static int
+static int ATTRIBUTE_PRINTF (3, 4)
 fprintf_styled (void *stream, enum disassembler_style style,
                const char *fmt, ...)
 {

diff --git a/sim/erc32/sis.c b/sim/erc32/sis.c
index 1d3ea139c23af37559c85ee653a292b0aee322a9..f89280b7c0c24596b151d4d13672b9a24b6f3279 100644 (file)
--- a/sim/erc32/sis.c
+++ b/sim/erc32/sis.c
@@ -138,7 +138,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis)
     return TIME_OUT;
 }
 
-static int
+static int ATTRIBUTE_PRINTF (3, 4)
 fprintf_styled (void *stream, enum disassembler_style style,
                const char *fmt, ...)
 {