Merge remote-tracking branch 'origin/master' into xaig_dff
authorEddie Hung <eddie@fpgeh.com>
Mon, 1 Jul 2019 17:44:42 +0000 (10:44 -0700)
committerEddie Hung <eddie@fpgeh.com>
Mon, 1 Jul 2019 17:44:42 +0000 (10:44 -0700)
1  2 
backends/aiger/xaiger.cc
frontends/aiger/aigerparse.cc
passes/techmap/abc9.cc
techlibs/xilinx/Makefile.inc
techlibs/xilinx/abc_xc7.box
techlibs/xilinx/synth_xilinx.cc

index 87dca014d2301698676b345a6c097013549a267b,eb3d475695b7f18d08e3f80d9ba5a37c86e5058f..8a35e06fa140cd3ac926926f4fc5a1bdf971cb7b
@@@ -76,13 -88,10 +91,14 @@@ struct XAigerWrite
  
        dict<SigBit, int> aig_map;
        dict<SigBit, int> ordered_outputs;
 +      dict<SigBit, int> ordered_latches;
  
        vector<Cell*> box_list;
+       bool omode = false;
  
 +      //dict<SigBit, int> init_inputs;
 +      //int initstate_ff = 0;
 +
        int mkgate(int a0, int a1)
        {
                aig_m++, aig_a++;
  
        int bit2aig(SigBit bit)
        {
-               if (aig_map.count(bit) == 0)
-               {
-                       aig_map[bit] = -1;
-                       if (not_map.count(bit)) {
-                               int a = bit2aig(not_map.at(bit)) ^ 1;
-                               aig_map[bit] = a;
-                       } else
-                       if (and_map.count(bit)) {
-                               auto args = and_map.at(bit);
-                               int a0 = bit2aig(args.first);
-                               int a1 = bit2aig(args.second);
-                               aig_map[bit] = mkgate(a0, a1);
-                       } else
-                       if (alias_map.count(bit)) {
-                               aig_map[bit] = bit2aig(alias_map.at(bit));
-                       }
+               auto it = aig_map.find(bit);
+               if (it != aig_map.end()) {
+                       log_assert(it->second >= 0);
+                       return it->second;
+               }
+               // NB: Cannot use iterator returned from aig_map.insert()
+               //     since this function is called recursively
+               int a = -1;
+               if (not_map.count(bit)) {
+                       a = bit2aig(not_map.at(bit)) ^ 1;
+               } else
+               if (and_map.count(bit)) {
+                       auto args = and_map.at(bit);
+                       int a0 = bit2aig(args.first);
+                       int a1 = bit2aig(args.second);
+                       a = mkgate(a0, a1);
+               } else
+               if (alias_map.count(bit)) {
+                       a = bit2aig(alias_map.at(bit));
+               }
  
-                       if (bit == State::Sx || bit == State::Sz)
-                               log_error("Design contains 'x' or 'z' bits. Use 'setundef' to replace those constants.\n");
+               if (bit == State::Sx || bit == State::Sz) {
+                       log_debug("Design contains 'x' or 'z' bits. Treating as 1'b0.\n");
+                       a = aig_map.at(State::S0);
                }
  
-               log_assert(aig_map.at(bit) >= 0);
-               return aig_map.at(bit);
+               log_assert(a >= 0);
+               aig_map[bit] = a;
+               return a;
        }
  
 -      XAigerWriter(Module *module, bool holes_mode=false) : module(module), sigmap(module)
 +      XAigerWriter(Module *module, bool zinit_mode, bool holes_mode=false) : module(module), zinit_mode(zinit_mode), sigmap(module)
        {
                pool<SigBit> undriven_bits;
                pool<SigBit> unused_bits;
                        aig_outputs.push_back(bit2aig(bit));
                }
  
 -              }
 +              for (auto bit : ff_bits) {
 +                      aig_o++;
 +                      aig_outputs.push_back(ff_aig_map.at(bit));
 +              }
++
+               if (output_bits.empty()) {
+                       aig_o++;
+                       aig_outputs.push_back(0);
+                       omode = true;
++        }
        }
  
        void write_aiger(std::ostream &f, bool ascii_mode)
                        f.write(reinterpret_cast<const char*>(&buffer_size_be), sizeof(buffer_size_be));
                        f.write(buffer_str.data(), buffer_str.size());
  
 +                      std::stringstream s_buffer;
 +                      auto write_s_buffer = std::bind(write_buffer, std::ref(s_buffer), std::placeholders::_1);
 +                      write_s_buffer(ff_bits.size());
 +                      for (auto bit : ff_bits) {
 +                              auto it = bit.wire->attributes.find("\\init");
 +                              if (it != bit.wire->attributes.end()) {
 +                                      auto init = it->second[bit.offset];
 +                                      if (init == RTLIL::S1) {
 +                                              write_s_buffer(1);
 +                                              continue;
 +                                      }
 +                              }
 +                              write_s_buffer(0);
 +                      }
 +                      f << "s";
 +                      buffer_str = s_buffer.str();
 +                      buffer_size_be = to_big_endian(buffer_str.size());
 +                      f.write(reinterpret_cast<const char*>(&buffer_size_be), sizeof(buffer_size_be));
 +                      f.write(buffer_str.data(), buffer_str.size());
 +
                        if (holes_module) {
+                               log_push();
                                // NB: fixup_ports() will sort ports by name
                                //holes_module->fixup_ports();
                                holes_module->check();
                for (auto &it : output_lines)
                        f << it.second;
                log_assert(output_lines.size() == output_bits.size());
+               if (omode && output_bits.empty())
+                       f << "output " << output_lines.size() << " 0 $__dummy__\n";
  
 +              latch_lines.sort();
 +              for (auto &it : latch_lines)
 +                      f << it.second;
 +
                wire_lines.sort();
                for (auto &it : wire_lines)
                        f << it.second;
index 60cbde857ad266b1431bd8c8c11cdb1e7ad35e15,1ac0f7ba465cc87fa735ba31c95e61a56d7384eb..7f81a4c893a89b50f432da621f2f8d69ed001471
@@@ -496,10 -506,11 +507,10 @@@ void AigerReader::parse_aiger_ascii(
  
        // Parse latches
        RTLIL::Wire *clk_wire = nullptr;
 -      if (L > 0) {
 -              log_assert(clk_name != "");
 +      if (L > 0 && !clk_name.empty()) {
                clk_wire = module->wire(clk_name);
                log_assert(!clk_wire);
-               log_debug("Creating %s\n", clk_name.c_str());
+               log_debug2("Creating %s\n", clk_name.c_str());
                clk_wire = module->addWire(clk_name);
                clk_wire->port_input = true;
                clk_wire->port_output = false;
@@@ -623,10 -631,11 +634,10 @@@ void AigerReader::parse_aiger_binary(
  
        // Parse latches
        RTLIL::Wire *clk_wire = nullptr;
 -      if (L > 0) {
 -              log_assert(clk_name != "");
 +      if (L > 0 && !clk_name.empty()) {
                clk_wire = module->wire(clk_name);
                log_assert(!clk_wire);
-               log_debug("Creating %s\n", clk_name.c_str());
+               log_debug2("Creating %s\n", clk_name.c_str());
                clk_wire = module->addWire(clk_name);
                clk_wire->port_input = true;
                clk_wire->port_output = false;
  
  void AigerReader::post_process()
  {
-       pool<RTLIL::Module*> abc_carry_modules;
+       pool<IdString> seen_boxes;
 -      unsigned ci_count = 0, co_count = 0;
 +      unsigned ci_count = 0, co_count = 0, flop_count = 0;
        for (auto cell : boxes) {
                RTLIL::Module* box_module = design->module(cell->type);
                log_assert(box_module);
  
 -              if (seen_boxes.insert(cell->type).second) {
 +              RTLIL::Module* flop_module = nullptr;
 +              auto flop_module_name = box_module->attributes.at("\\abc_flop", RTLIL::Const());
 +              RTLIL::IdString flop_past_q;
 +              if (flop_module_name.size() > 0) {
 +                      log_assert(flop_count < flopNum);
 +                      flop_module = design->module(RTLIL::escape_id(flop_module_name.decode_string()));
 +                      log_assert(flop_module);
 +                      flop_past_q = box_module->attributes.at("\\abc_flop_past_q").decode_string();
 +              }
-               else if (box_module->attributes.count("\\abc_carry") && !abc_carry_modules.count(box_module)) {
-                       RTLIL::Wire* carry_in = nullptr, *carry_out = nullptr;
-                       RTLIL::Wire* last_in = nullptr, *last_out = nullptr;
-                       for (const auto &port_name : box_module->ports) {
-                               RTLIL::Wire* w = box_module->wire(port_name);
-                               log_assert(w);
-                               if (w->port_input) {
-                                       if (w->attributes.count("\\abc_carry_in")) {
-                                               log_assert(!carry_in);
-                                               carry_in = w;
++        else if (seen_boxes.insert(cell->type).second) {
+                       auto it = box_module->attributes.find("\\abc_carry");
+                       if (it != box_module->attributes.end()) {
+                               RTLIL::Wire *carry_in = nullptr, *carry_out = nullptr;
+                               auto carry_in_out = it->second.decode_string();
+                               auto pos = carry_in_out.find(',');
+                               if (pos == std::string::npos)
+                                       log_error("'abc_carry' attribute on module '%s' does not contain ','.\n", log_id(cell->type));
+                               auto carry_in_name = RTLIL::escape_id(carry_in_out.substr(0, pos));
+                               carry_in = box_module->wire(carry_in_name);
+                               if (!carry_in || !carry_in->port_input)
+                                       log_error("'abc_carry' on module '%s' contains '%s' which does not exist or is not an input port.\n", log_id(cell->type), carry_in_name.c_str());
+                               auto carry_out_name = RTLIL::escape_id(carry_in_out.substr(pos+1));
+                               carry_out = box_module->wire(carry_out_name);
+                               if (!carry_out || !carry_out->port_output)
+                                       log_error("'abc_carry' on module '%s' contains '%s' which does not exist or is not an output port.\n", log_id(cell->type), carry_out_name.c_str());
+                               auto &ports = box_module->ports;
+                               for (auto jt = ports.begin(); jt != ports.end(); ) {
+                                       RTLIL::Wire* w = box_module->wire(*jt);
+                                       log_assert(w);
+                                       if (w == carry_in || w == carry_out) {
+                                               jt = ports.erase(jt);
+                                               continue;
                                        }
-                                       log_assert(!last_in || last_in->port_id < w->port_id);
-                                       last_in = w;
+                                       if (w->port_id > carry_in->port_id)
+                                               --w->port_id;
+                                       if (w->port_id > carry_out->port_id)
+                                               --w->port_id;
+                                       log_assert(w->port_input || w->port_output);
+                                       log_assert(ports[w->port_id-1] == w->name);
+                                       ++jt;
                                }
-                               if (w->port_output) {
-                                       if (w->attributes.count("\\abc_carry_out")) {
-                                               log_assert(!carry_out);
-                                               carry_out = w;
-                                       }
-                                       log_assert(!last_out || last_out->port_id < w->port_id);
-                                       last_out = w;
-                               }
-                       }
-                       if (carry_in != last_in) {
-                               std::swap(box_module->ports[carry_in->port_id], box_module->ports[last_in->port_id]);
-                               std::swap(carry_in->port_id, last_in->port_id);
-                       }
-                       if (carry_out != last_out) {
-                               log_assert(last_out);
-                               std::swap(box_module->ports[carry_out->port_id], box_module->ports[last_out->port_id]);
-                               std::swap(carry_out->port_id, last_out->port_id);
+                               ports.push_back(carry_in->name);
+                               carry_in->port_id = ports.size();
+                               ports.push_back(carry_out->name);
+                               carry_out->port_id = ports.size();
                        }
                }
  
index f56350b1dca74f8e619141ab61d0d3f727f4d71c,f107f994794c2dc1f5afc375b296127cd553603b..2eee43739666264e69fbe63d5976cfbee8a4d499
@@@ -498,15 -539,9 +542,15 @@@ void abc9_module(RTLIL::Design *design
                        if (w->port_output) {
                                RTLIL::Wire *wire = module->wire(w->name);
                                log_assert(wire);
-                               for (int i = 0; i < GetSize(wire); i++)
+                               for (int i = 0; i < GetSize(w); i++)
                                        output_bits.insert({wire, i});
                        }
 +
 +                      auto jt = w->attributes.find("\\init");
 +                      if (jt != w->attributes.end()) {
 +                              auto r = remap_wire->attributes.insert(std::make_pair("\\init", jt->second));
 +                              log_assert(r.second);
 +                      }
                }
  
                for (auto &it : module->connections_) {
index 12ec20053b29bfaed9ca4e58c0637fa9da71d417,e9ea10e48cf35e85b4a56d4ceca93e7c0c1ed8c1..860fcd88c18754880b648d7ae18c90d785039606
@@@ -30,9 -30,10 +30,11 @@@ $(eval $(call add_share_file,share/xili
  $(eval $(call add_share_file,share/xilinx,techlibs/xilinx/arith_map.v))
  $(eval $(call add_share_file,share/xilinx,techlibs/xilinx/ff_map.v))
  $(eval $(call add_share_file,share/xilinx,techlibs/xilinx/lut_map.v))
 +$(eval $(call add_share_file,share/xilinx,techlibs/xilinx/abc_ff.v))
  $(eval $(call add_share_file,share/xilinx,techlibs/xilinx/abc_xc7.box))
  $(eval $(call add_share_file,share/xilinx,techlibs/xilinx/abc_xc7.lut))
+ $(eval $(call add_share_file,share/xilinx,techlibs/xilinx/abc_xc7_nowide.lut))
  
  $(eval $(call add_gen_share_file,share/xilinx,techlibs/xilinx/brams_init_36.vh))
  $(eval $(call add_gen_share_file,share/xilinx,techlibs/xilinx/brams_init_32.vh))
index 4caf693209b4a42621bd9754abce3f8021656605,6dd71d75875a3bb769f818b7a76a3ce148a73385..bb9258e789c5c2f2e2c8b4403d16b110873e8489
@@@ -37,26 -48,6 +48,26 @@@ RAM64X1D 5 0 15 
  # SLICEM/A6LUT + F7[AB]MUX
  # Inputs: A0 A1 A2 A3 A4 A5 A6 D DPRA0 DPRA1 DPRA2 DPRA3 DPRA4 DPRA5 DPRA6 WCLK WE
  # Outputs: DPO SPO
- RAM128X1D 5 0 17 2
- -   -   -   -   -   -   -   - 314 314 314 314 314 314 292 - -
- 347 347 347 347 347 347 296 - -   -   -   -   -   -   -   - -
+ RAM128X1D 6 0 17 2
+ -    -    -   -   -   -   -   - 1009 998 839 774 605 494 450 - -
+ 1047 1036 877 812 643 532 478 - -    -   -   -   -   -   -   - -
 +
 +# Inputs: C CE D R \$pastQ
 +# Outputs: Q
 +FDRE 6 1 5 1
 +- 109 -46 358 0
 +
 +# Inputs: C CE D S \$pastQ
 +# Outputs: Q
 +FDSE 7 0 5 1
 +- 109 -46 358 0
 +
 +# Inputs: C CE CLR D \$pastQ
 +# Outputs: Q
 +FDCE 8 0 5 1
 +- 109 - -46 0
 +
 +# Inputs: C CE D PRE \$pastQ
 +# Outputs: Q
 +FDPE 9 0 5 1
 +- 109 -46 - 0
index d3f0962207d6e03e98d9c743e1d16810191fc269,b7c32d2e052ff020d7acbc8b2e4ee424ed8e5743..cdc64db1d73b24fe64fb7bd31ca316e418357ea2
@@@ -276,32 -285,35 +285,42 @@@ struct SynthXilinxPass : public ScriptP
                }
  
                if (check_label("map_cells")) {
-                       if (abc == "abc9")
 -                      run("techmap -map +/techmap.v -map +/xilinx/cells_map.v");
++                      if (abc9)
 +                              run("techmap -map +/techmap.v -map +/xilinx/cells_map.v -D _ABC -map +/xilinx/ff_map.v");
 +                      else
 +                              run("techmap -map +/techmap.v -map +/xilinx/cells_map.v");
                        run("clean");
                }
  
                if (check_label("map_luts")) {
-                       if (abc == "abc9") {
+                       run("opt_expr -mux_undef");
+                       if (help_mode)
+                               run("abc -luts 2:2,3,6:5[,10,20] [-dff]", "(skip if 'nowidelut', only for '-retime')");
+                       else if (abc9) {
+                               if (family != "xc7")
+                                       log_warning("'synth_xilinx -abc9' currently supports '-family xc7' only.\n");
 +                              run("read_verilog -icells -lib +/xilinx/abc_ff.v");
-                               run(abc + " -lut +/xilinx/abc_xc7.lut -box +/xilinx/abc_xc7.box -W " + XC7_WIRE_DELAY + string(retime ? " -retime" : ""));
+                               if (nowidelut)
+                                       run("abc9 -lut +/xilinx/abc_xc7_nowide.lut -box +/xilinx/abc_xc7.box -W " + std::string(XC7_WIRE_DELAY) + string(retime ? " -dff" : ""));
+                               else
+                                       run("abc9 -lut +/xilinx/abc_xc7.lut -box +/xilinx/abc_xc7.box -W " + std::string(XC7_WIRE_DELAY) + string(retime ? " -dff" : ""));
+                       }
+                       else {
+                               if (nowidelut)
+                                       run("abc -luts 2:2,3,6:5" + string(retime ? " -dff" : ""));
+                               else
+                                       run("abc -luts 2:2,3,6:5,10,20" + string(retime ? " -dff" : ""));
                        }
-                       else if (help_mode)
-                               run(abc + " -luts 2:2,3,6:5,10,20 [-dff]");
-                       else
-                               run(abc + " -luts 2:2,3,6:5,10,20" + string(retime ? " -dff" : ""));
                        run("clean");
  
                        // This shregmap call infers fixed length shift registers after abc
                        //   has performed any necessary retiming
                        if (!nosrl || help_mode)
                                run("shregmap -minlen 3 -init -params -enpol any_or_none", "(skip if '-nosrl')");
-                       if (abc == "abc9")
 -                      run("techmap -map +/xilinx/lut_map.v -map +/xilinx/ff_map.v -map +/xilinx/cells_map.v");
++                      if (abc9)
 +                              run("techmap -map +/xilinx/lut_map.v -map +/xilinx/cells_map.v");
 +                      else
 +                              run("techmap -map +/xilinx/lut_map.v -map +/xilinx/cells_map.v -map +/xilinx/ff_map.v");
                        run("dffinit -ff FDRE Q INIT -ff FDCE Q INIT -ff FDPE Q INIT -ff FDSE Q INIT "
                                        "-ff FDRE_1 Q INIT -ff FDCE_1 Q INIT -ff FDPE_1 Q INIT -ff FDSE_1 Q INIT");
                        run("clean");