pan/bi: Don't gobble zero ports

In case we've reading/writing R0.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4458>

diff --git a/src/panfrost/bifrost/bi_pack.c b/src/panfrost/bifrost/bi_pack.c
index 8f006edebe0acbd372c086d03b3f024e207f65ac..8cd4dd3b91610c999eb111022caae32bafaba337 100644 (file)
--- a/src/panfrost/bifrost/bi_pack.c
+++ b/src/panfrost/bifrost/bi_pack.c
@@ -363,12 +363,15 @@ bi_pack_registers(struct bi_registers regs)
         }
 
         /* When port 3 isn't used, we have to set it to port 2, and vice versa,
-         * or we an INSTR_INVALID_ENC is raised. The reason is unknown. */
+         * or INSTR_INVALID_ENC is raised. The reason is unknown. */
 
-        if (!regs.port[3])
+        bool has_port2 = regs.write_fma || regs.write_add;
+        bool has_port3 = regs.read_port3 || (regs.write_fma && regs.write_add);
+
+        if (!has_port3)
                 regs.port[3] = regs.port[2];
 
-        if (!regs.port[2])
+        if (!has_port2)
                 regs.port[2] = regs.port[3];
 
         s.reg3 = regs.port[3];