* options.cc (parse_uint): Fix dereference of RETVAL.

diff --git a/gold/ChangeLog b/gold/ChangeLog
index e12a151b09b36c83dd6289483fdb37aa258c09e8..9f1083c79a8d5fdb2af46b6110f67a9fb08e90e6 100644 (file)
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,7 @@
+2011-10-03   Diego Novillo  <dnovillo@google.com>
+
+       * options.cc (parse_uint): Fix dereference of RETVAL.
+
 2011-09-29  Sriraman Tallam  <tmsriram@google.com>
 
        * layout.h (section_order_map_): New member.

diff --git a/gold/options.cc b/gold/options.cc
index d91a8343f9feb83c710d3f360f73518ce14d7501..dcf6ba71ace25c080fa3d479cd09bbf94f1be921 100644 (file)
--- a/gold/options.cc
+++ b/gold/options.cc
@@ -198,7 +198,7 @@ parse_uint(const char* option_name, const char* arg, int* retval)
 {
   char* endptr;
   *retval = strtol(arg, &endptr, 0);
-  if (*endptr != '\0' || retval < 0)
+  if (*endptr != '\0' || *retval < 0)
     gold_fatal(_("%s: invalid option value (expected an integer): %s"),
                option_name, arg);
 }