sim: cgen: tweak cgen_rtx_error to fix warnings

The function was missing a prototype, and passing a constant string
as the format string instead of going through a %s format.

diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog
index 0795a701c01a60a19e95bbf41e1160d056deb5f9..a3f6f38d7dfaf39a52c8657f8225740b118b06dc 100644 (file)
--- a/sim/common/ChangeLog
+++ b/sim/common/ChangeLog
@@ -1,3 +1,8 @@
+2021-05-08  Mike Frysinger  <vapier@gentoo.org>
+
+       * cgen-ops.h (cgen_rtx_error): Declare.
+       * cgen-utils.c (cgen_rtx_error): Add %s printf argument.
+
 2021-05-08  Mike Frysinger  <vapier@gentoo.org>
 
        * cgen-utils.c (virtual_insn_entries): Change {0} to {}.

diff --git a/sim/common/cgen-ops.h b/sim/common/cgen-ops.h
index 329d7de285afa898b149654dda2dc3233b9d713b..86a483528a337f7c8d027098e5245d12b15c1d4b 100644 (file)
--- a/sim/common/cgen-ops.h
+++ b/sim/common/cgen-ops.h
@@ -708,4 +708,6 @@ BI SUBOFDI (DI a, DI b, BI c);
 
 #endif
 
+extern void cgen_rtx_error (SIM_CPU *, const char *);
+
 #endif /* CGEN_SEM_OPS_H */

diff --git a/sim/common/cgen-utils.c b/sim/common/cgen-utils.c
index a22caabbbd8ef42fe8cd0db65e3c64256f7c0876..a430427bf12a239f972090908d1d602e61b541d8 100644 (file)
--- a/sim/common/cgen-utils.c
+++ b/sim/common/cgen-utils.c
@@ -416,7 +416,7 @@ cgen_rtx_error (SIM_CPU *cpu, const char * msg)
 {
   SIM_DESC sd = CPU_STATE (cpu);
 
-  sim_io_printf (sd, msg);
+  sim_io_printf (sd, "%s", msg);
   sim_io_printf (sd, "\n");
 
   sim_engine_halt (sd, cpu, NULL, CPU_PC_GET (cpu), sim_stopped, SIM_SIGTRAP);