mem: fixupAddr should not panic if it fails.
authorGabe Black <gabeblack@google.com>
Wed, 17 Jun 2020 01:42:48 +0000 (18:42 -0700)
committerGabe Black <gabeblack@google.com>
Thu, 18 Jun 2020 03:58:48 +0000 (03:58 +0000)
This function should just return false in that case, and its callers
should figure out what to do. Otherwise, when calling tryReadBlob in SE
mode, a failure to read the blob makes gem5 panic instead of just
returning false.

Change-Id: I74b9cb98f595c52300d683842ece68c6031d9b85
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30376
Reviewed-by: Sandipan Das <sandipan@linux.ibm.com>
Reviewed-by: Matthew Poremba <matthew.poremba@amd.com>
Maintainer: Gabe Black <gabeblack@google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/mem/se_translating_port_proxy.cc

index bc1153ef126d5634899be7c72f96bc8d5f919521..a8a42d04de94ef83e81d2bc3a78474281067fcf2 100644 (file)
@@ -62,6 +62,5 @@ SETranslatingPortProxy::fixupAddr(Addr addr, BaseTLB::Mode mode) const
             return true;
         }
     }
-    panic("Page table fault when accessing virtual address %#x "
-          "during functional write.", addr);
+    return false;
 }