gdb: add declaration to Python init function

When I try to enable -Wmissing-declarations, I get this error:

      CXX    python/python.o
    /home/smarchi/src/binutils-gdb/gdb/python/python.c: In function ‘PyObject* init__gdb_module()’:
    /home/smarchi/src/binutils-gdb/gdb/python/python.c:1582:1: error: no previous declaration for ‘PyObject* init__gdb_module()’ [-Werror=missing-declarations]
     init__gdb_module (void)
     ^~~~~~~~~~~~~~~~

Prevent it by providing a declaration just before the definition.

gdb/ChangeLog:

	* python/python.c (init__gdb_module): Add declaration.

Change-Id: I394bc691b7db624708cc4cb2cda28a56ab85a82b

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a9db32253da05bc055f330e9e6f252b716f95f00..f2992f17844bbac7d1c58bb33fe1c78cdf24ad7a 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
+
+       * python/python.c (init__gdb_module): Add declaration.
+
 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
 
        * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.

diff --git a/gdb/python/python.c b/gdb/python/python.c
index f7aadb1633c8e0752e22aa4d5caa15425f96caaa..e0c05f1d0689ee1c4d47045e3bdc43d19083d6e3 100644 (file)
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -1555,6 +1555,7 @@ finalize_python (void *ignore)
 /* This is called via the PyImport_AppendInittab mechanism called
    during initialization, to make the built-in _gdb module known to
    Python.  */
+PyMODINIT_FUNC init__gdb_module (void);
 PyMODINIT_FUNC
 init__gdb_module (void)
 {