Fix value_literal_complex comment

Christian pointed out that the value_literal_complex was still a bit
weird; this patch rewrites it and moves it to value.h.

gdb/ChangeLog
2020-04-01  Tom Tromey  <tom@tromey.com>

	* value.h (value_literal_complex): Add comment.
	* valops.c (value_literal_complex): Refer to value.h.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 61d30070e374aed0250dd838c5fb068eab337f32..12f099559b85f2b571838b72fdd4cc6ec31a870f 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-04-01  Tom Tromey  <tom@tromey.com>
+
+       * value.h (value_literal_complex): Add comment.
+       * valops.c (value_literal_complex): Refer to value.h.
+
 2020-04-01  Tom Tromey  <tom@tromey.com>
 
        * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.

diff --git a/gdb/valops.c b/gdb/valops.c
index 83fd2584b597475bc8a24646cbc6656f3c7d8d8b..03c6482ee1e9136a54b8a6327f67bd51ee941032 100644 (file)
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -3854,12 +3854,10 @@ value_slice (struct value *array, int lowbound, int length)
   return slice;
 }
 
-/* Create a value for a FORTRAN complex number.  Currently most of the
-   time values are coerced to COMPLEX*16 (i.e. a complex number
-   composed of 2 doubles.  */
+/* See value.h.  */
 
 struct value *
-value_literal_complex (struct value *arg1, 
+value_literal_complex (struct value *arg1,
                       struct value *arg2,
                       struct type *type)
 {

diff --git a/gdb/value.h b/gdb/value.h
index 85fe6c297f50d3f39b43cd92be99d900d3604c71..247be13a0d991f270da47ee81aa3f5dbd72e9adc 100644 (file)
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -1138,6 +1138,10 @@ extern struct value *varying_to_slice (struct value *);
 
 extern struct value *value_slice (struct value *, int, int);
 
+/* Create a complex number.  The type is the complex type; the values
+   are cast to the underlying scalar type before the complex number is
+   created.  */
+
 extern struct value *value_literal_complex (struct value *, struct value *,
                                            struct type *);