re PR c/32511 (GCC rejects inline+weak function)

2008-03-27  Richard Guenther  <rguenther@suse.de>

	PR c/32511
	* c-common.c (handle_weak_attribute): Reject combination of
	weak and inline.

	* gcc.dg/attr-weak-1.c: New testcase.

From-SVN: r133646

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 215f0b26728755b2a786a206119b4d03c3c1dae1..19cb5670f755c6a8b8c3621373ad77533b0a9e7f 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2008-03-27  Richard Guenther  <rguenther@suse.de>
+
+       PR c/32511
+       * c-common.c (handle_weak_attribute): Reject combination of
+       weak and inline.
+
 2008-03-27  Richard Guenther  <rguenther@suse.de>
 
        PR tree-optimization/32810

diff --git a/gcc/c-common.c b/gcc/c-common.c
index 1b6297452394ec2e5af47f7f00c59a033727020c..7e609deeb50dd816754a28d4e558be1f4063a61a 100644 (file)
--- a/gcc/c-common.c
+++ b/gcc/c-common.c
@@ -5518,11 +5518,16 @@ handle_weak_attribute (tree *node, tree name,
                       bool * ARG_UNUSED (no_add_attrs))
 {
   if (TREE_CODE (*node) == FUNCTION_DECL
-      || TREE_CODE (*node) == VAR_DECL)
+      && DECL_DECLARED_INLINE_P (*node))
+    {
+      error ("inline function %q+D cannot be declared weak", *node);
+      *no_add_attrs = true;
+    }
+  else if (TREE_CODE (*node) == FUNCTION_DECL
+          || TREE_CODE (*node) == VAR_DECL)
     declare_weak (*node);
   else
     warning (OPT_Wattributes, "%qE attribute ignored", name);
-       
 
   return NULL_TREE;
 }

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index abaed69e399269f75234b99e9cef42a9656649a0..175289686e6c130960c60b0aff8e15147479dd3a 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2008-03-27  Richard Guenther  <rguenther@suse.de>
+
+       PR c/32511
+       * gcc.dg/attr-weak-1.c: New testcase.
+
 2008-03-27  Richard Guenther  <rguenther@suse.de>
 
        PR tree-optimization/32810

diff --git a/gcc/testsuite/gcc.dg/attr-weak-1.c b/gcc/testsuite/gcc.dg/attr-weak-1.c
new file mode 100644 (file)
index 0000000..014e37d
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/attr-weak-1.c
@@ -0,0 +1,4 @@
+/* { dg-do compile } */
+
+__inline void foo(void) __attribute__((weak));  /* { dg-error "inline.*weak" } */
+