Clean up pseudo-private member usage in `passes/sat/miter.cc`.
authorAlberto Gonzalez <boqwxp@airmail.cc>
Thu, 19 Mar 2020 06:22:42 +0000 (06:22 +0000)
committerAlberto Gonzalez <boqwxp@airmail.cc>
Thu, 19 Mar 2020 07:07:22 +0000 (07:07 +0000)
passes/sat/miter.cc

index 49ef4006156ab6fd8c8f252b0f080434ed765d8c..7424339358b667ccf5c439ca0002b402e5155415 100644 (file)
@@ -66,50 +66,48 @@ void create_miter_equiv(struct Pass *that, std::vector<std::string> args, RTLIL:
        RTLIL::IdString gate_name = RTLIL::escape_id(args[argidx++]);
        RTLIL::IdString miter_name = RTLIL::escape_id(args[argidx++]);
 
-       if (design->modules_.count(gold_name) == 0)
+       if (design->module(gold_name) == nullptr)
                log_cmd_error("Can't find gold module %s!\n", gold_name.c_str());
-       if (design->modules_.count(gate_name) == 0)
+       if (design->module(gate_name) == nullptr)
                log_cmd_error("Can't find gate module %s!\n", gate_name.c_str());
-       if (design->modules_.count(miter_name) != 0)
+       if (design->module(miter_name) != nullptr)
                log_cmd_error("There is already a module %s!\n", miter_name.c_str());
 
-       RTLIL::Module *gold_module = design->modules_.at(gold_name);
-       RTLIL::Module *gate_module = design->modules_.at(gate_name);
+       RTLIL::Module *gold_module = design->module(gold_name);
+       RTLIL::Module *gate_module = design->module(gate_name);
 
-       for (auto &it : gold_module->wires_) {
-               RTLIL::Wire *w1 = it.second, *w2;
-               if (w1->port_id == 0)
+       for (auto gold_wire : gold_module->wires()) {
+               if (gold_wire->port_id == 0)
                        continue;
-               if (gate_module->wires_.count(it.second->name) == 0)
+               RTLIL::Wire *gate_wire = gate_module->wire(gold_wire->name);
+               if (gate_wire == nullptr)
                        goto match_gold_port_error;
-               w2 = gate_module->wires_.at(it.second->name);
-               if (w1->port_input != w2->port_input)
+               if (gold_wire->port_input != gate_wire->port_input)
                        goto match_gold_port_error;
-               if (w1->port_output != w2->port_output)
+               if (gold_wire->port_output != gate_wire->port_output)
                        goto match_gold_port_error;
-               if (w1->width != w2->width)
+               if (gold_wire->width != gate_wire->width)
                        goto match_gold_port_error;
                continue;
        match_gold_port_error:
-               log_cmd_error("No matching port in gate module was found for %s!\n", it.second->name.c_str());
+               log_cmd_error("No matching port in gate module was found for %s!\n", gold_wire->name.c_str());
        }
 
-       for (auto &it : gate_module->wires_) {
-               RTLIL::Wire *w1 = it.second, *w2;
-               if (w1->port_id == 0)
+       for (auto gate_wire : gate_module->wires()) {
+               if (gate_wire->port_id == 0)
                        continue;
-               if (gold_module->wires_.count(it.second->name) == 0)
+               RTLIL::Wire *gold_wire = gold_module->wire(gate_wire->name);
+               if (gold_wire == nullptr)
                        goto match_gate_port_error;
-               w2 = gold_module->wires_.at(it.second->name);
-               if (w1->port_input != w2->port_input)
+               if (gate_wire->port_input != gold_wire->port_input)
                        goto match_gate_port_error;
-               if (w1->port_output != w2->port_output)
+               if (gate_wire->port_output != gold_wire->port_output)
                        goto match_gate_port_error;
-               if (w1->width != w2->width)
+               if (gate_wire->width != gold_wire->width)
                        goto match_gate_port_error;
                continue;
        match_gate_port_error:
-               log_cmd_error("No matching port in gold module was found for %s!\n", it.second->name.c_str());
+               log_cmd_error("No matching port in gold module was found for %s!\n", gate_wire->name.c_str());
        }
 
        log("Creating miter cell \"%s\" with gold cell \"%s\" and gate cell \"%s\".\n", RTLIL::id2cstr(miter_name), RTLIL::id2cstr(gold_name), RTLIL::id2cstr(gate_name));
@@ -123,73 +121,71 @@ void create_miter_equiv(struct Pass *that, std::vector<std::string> args, RTLIL:
 
        RTLIL::SigSpec all_conditions;
 
-       for (auto &it : gold_module->wires_)
+       for (auto gold_wire : gold_module->wires())
        {
-               RTLIL::Wire *w1 = it.second;
-
-               if (w1->port_input)
+               if (gold_wire->port_input)
                {
-                       RTLIL::Wire *w2 = miter_module->addWire("\\in_" + RTLIL::unescape_id(w1->name), w1->width);
-                       w2->port_input = true;
+                       RTLIL::Wire *w = miter_module->addWire("\\in_" + RTLIL::unescape_id(gold_wire->name), gold_wire->width);
+                       w->port_input = true;
 
-                       gold_cell->setPort(w1->name, w2);
-                       gate_cell->setPort(w1->name, w2);
+                       gold_cell->setPort(gold_wire->name, w);
+                       gate_cell->setPort(gold_wire->name, w);
                }
 
-               if (w1->port_output)
+               if (gold_wire->port_output)
                {
-                       RTLIL::Wire *w2_gold = miter_module->addWire("\\gold_" + RTLIL::unescape_id(w1->name), w1->width);
-                       w2_gold->port_output = flag_make_outputs;
+                       RTLIL::Wire *w_gold = miter_module->addWire("\\gold_" + RTLIL::unescape_id(gold_wire->name), gold_wire->width);
+                       w_gold->port_output = flag_make_outputs;
 
-                       RTLIL::Wire *w2_gate = miter_module->addWire("\\gate_" + RTLIL::unescape_id(w1->name), w1->width);
-                       w2_gate->port_output = flag_make_outputs;
+                       RTLIL::Wire *w_gate = miter_module->addWire("\\gate_" + RTLIL::unescape_id(gold_wire->name), gold_wire->width);
+                       w_gate->port_output = flag_make_outputs;
 
-                       gold_cell->setPort(w1->name, w2_gold);
-                       gate_cell->setPort(w1->name, w2_gate);
+                       gold_cell->setPort(gold_wire->name, w_gold);
+                       gate_cell->setPort(gold_wire->name, w_gate);
 
                        RTLIL::SigSpec this_condition;
 
                        if (flag_ignore_gold_x)
                        {
-                               RTLIL::SigSpec gold_x = miter_module->addWire(NEW_ID, w2_gold->width);
-                               for (int i = 0; i < w2_gold->width; i++) {
+                               RTLIL::SigSpec gold_x = miter_module->addWire(NEW_ID, w_gold->width);
+                               for (int i = 0; i < w_gold->width; i++) {
                                        RTLIL::Cell *eqx_cell = miter_module->addCell(NEW_ID, "$eqx");
                                        eqx_cell->parameters["\\A_WIDTH"] = 1;
                                        eqx_cell->parameters["\\B_WIDTH"] = 1;
                                        eqx_cell->parameters["\\Y_WIDTH"] = 1;
                                        eqx_cell->parameters["\\A_SIGNED"] = 0;
                                        eqx_cell->parameters["\\B_SIGNED"] = 0;
-                                       eqx_cell->setPort("\\A", RTLIL::SigSpec(w2_gold, i));
+                                       eqx_cell->setPort("\\A", RTLIL::SigSpec(w_gold, i));
                                        eqx_cell->setPort("\\B", RTLIL::State::Sx);
                                        eqx_cell->setPort("\\Y", gold_x.extract(i, 1));
                                }
 
-                               RTLIL::SigSpec gold_masked = miter_module->addWire(NEW_ID, w2_gold->width);
-                               RTLIL::SigSpec gate_masked = miter_module->addWire(NEW_ID, w2_gate->width);
+                               RTLIL::SigSpec gold_masked = miter_module->addWire(NEW_ID, w_gold->width);
+                               RTLIL::SigSpec gate_masked = miter_module->addWire(NEW_ID, w_gate->width);
 
                                RTLIL::Cell *or_gold_cell = miter_module->addCell(NEW_ID, "$or");
-                               or_gold_cell->parameters["\\A_WIDTH"] = w2_gold->width;
-                               or_gold_cell->parameters["\\B_WIDTH"] = w2_gold->width;
-                               or_gold_cell->parameters["\\Y_WIDTH"] = w2_gold->width;
+                               or_gold_cell->parameters["\\A_WIDTH"] = w_gold->width;
+                               or_gold_cell->parameters["\\B_WIDTH"] = w_gold->width;
+                               or_gold_cell->parameters["\\Y_WIDTH"] = w_gold->width;
                                or_gold_cell->parameters["\\A_SIGNED"] = 0;
                                or_gold_cell->parameters["\\B_SIGNED"] = 0;
-                               or_gold_cell->setPort("\\A", w2_gold);
+                               or_gold_cell->setPort("\\A", w_gold);
                                or_gold_cell->setPort("\\B", gold_x);
                                or_gold_cell->setPort("\\Y", gold_masked);
 
                                RTLIL::Cell *or_gate_cell = miter_module->addCell(NEW_ID, "$or");
-                               or_gate_cell->parameters["\\A_WIDTH"] = w2_gate->width;
-                               or_gate_cell->parameters["\\B_WIDTH"] = w2_gate->width;
-                               or_gate_cell->parameters["\\Y_WIDTH"] = w2_gate->width;
+                               or_gate_cell->parameters["\\A_WIDTH"] = w_gate->width;
+                               or_gate_cell->parameters["\\B_WIDTH"] = w_gate->width;
+                               or_gate_cell->parameters["\\Y_WIDTH"] = w_gate->width;
                                or_gate_cell->parameters["\\A_SIGNED"] = 0;
                                or_gate_cell->parameters["\\B_SIGNED"] = 0;
-                               or_gate_cell->setPort("\\A", w2_gate);
+                               or_gate_cell->setPort("\\A", w_gate);
                                or_gate_cell->setPort("\\B", gold_x);
                                or_gate_cell->setPort("\\Y", gate_masked);
 
                                RTLIL::Cell *eq_cell = miter_module->addCell(NEW_ID, "$eqx");
-                               eq_cell->parameters["\\A_WIDTH"] = w2_gold->width;
-                               eq_cell->parameters["\\B_WIDTH"] = w2_gate->width;
+                               eq_cell->parameters["\\A_WIDTH"] = w_gold->width;
+                               eq_cell->parameters["\\B_WIDTH"] = w_gate->width;
                                eq_cell->parameters["\\Y_WIDTH"] = 1;
                                eq_cell->parameters["\\A_SIGNED"] = 0;
                                eq_cell->parameters["\\B_SIGNED"] = 0;
@@ -201,20 +197,20 @@ void create_miter_equiv(struct Pass *that, std::vector<std::string> args, RTLIL:
                        else
                        {
                                RTLIL::Cell *eq_cell = miter_module->addCell(NEW_ID, "$eqx");
-                               eq_cell->parameters["\\A_WIDTH"] = w2_gold->width;
-                               eq_cell->parameters["\\B_WIDTH"] = w2_gate->width;
+                               eq_cell->parameters["\\A_WIDTH"] = w_gold->width;
+                               eq_cell->parameters["\\B_WIDTH"] = w_gate->width;
                                eq_cell->parameters["\\Y_WIDTH"] = 1;
                                eq_cell->parameters["\\A_SIGNED"] = 0;
                                eq_cell->parameters["\\B_SIGNED"] = 0;
-                               eq_cell->setPort("\\A", w2_gold);
-                               eq_cell->setPort("\\B", w2_gate);
+                               eq_cell->setPort("\\A", w_gold);
+                               eq_cell->setPort("\\B", w_gate);
                                eq_cell->setPort("\\Y", miter_module->addWire(NEW_ID));
                                this_condition = eq_cell->getPort("\\Y");
                        }
 
                        if (flag_make_outcmp)
                        {
-                               RTLIL::Wire *w_cmp = miter_module->addWire("\\cmp_" + RTLIL::unescape_id(w1->name));
+                               RTLIL::Wire *w_cmp = miter_module->addWire("\\cmp_" + RTLIL::unescape_id(gold_wire->name));
                                w_cmp->port_output = true;
                                miter_module->connect(RTLIL::SigSig(w_cmp, this_condition));
                        }
@@ -285,9 +281,9 @@ void create_miter_assert(struct Pass *that, std::vector<std::string> args, RTLIL
        IdString module_name = RTLIL::escape_id(args[argidx++]);
        IdString miter_name = argidx < args.size() ? RTLIL::escape_id(args[argidx++]) : "";
 
-       if (design->modules_.count(module_name) == 0)
+       if (design->module(module_name) == nullptr)
                log_cmd_error("Can't find module %s!\n", module_name.c_str());
-       if (!miter_name.empty() && design->modules_.count(miter_name) != 0)
+       if (!miter_name.empty() && design->module(miter_name) != nullptr)
                log_cmd_error("There is already a module %s!\n", miter_name.c_str());
 
        Module *module = design->module(module_name);