tree: Fix up get_narrower [PR96549]
authorJakub Jelinek <jakub@redhat.com>
Tue, 11 Aug 2020 11:46:14 +0000 (13:46 +0200)
committerJakub Jelinek <jakub@redhat.com>
Tue, 11 Aug 2020 11:51:46 +0000 (13:51 +0200)
My changes to get_narrower to support COMPOUND_EXPRs apparently
used a wrong type for the COMPOUND_EXPRs, while e.g. the rhs
type was unsigned short, the COMPOUND_EXPR got int type as that was the
original type of op.  The type of COMPOUND_EXPR should be always the type
of the rhs.

2020-08-11  Jakub Jelinek  <jakub@redhat.com>

PR c/96549
* tree.c (get_narrower): Use TREE_TYPE (ret) instead of
TREE_TYPE (win) for COMPOUND_EXPRs.

* gcc.c-torture/execute/pr96549.c: New test.

gcc/testsuite/gcc.c-torture/execute/pr96549.c [new file with mode: 0644]
gcc/tree.c

diff --git a/gcc/testsuite/gcc.c-torture/execute/pr96549.c b/gcc/testsuite/gcc.c-torture/execute/pr96549.c
new file mode 100644 (file)
index 0000000..9d992a8
--- /dev/null
@@ -0,0 +1,12 @@
+/* PR c/96549 */
+
+long c = -1L;
+long b = 0L;
+
+int
+main ()
+{
+  if (3L > (short) ((c ^= (b = 1L)) * 3L))
+    return 0;
+  __builtin_abort ();
+}
index 6dea32aeb45bd1b8f62bd9d5f7f07ca4111edfc9..d0202c3f7851e91bc7ba76f8202bf5969d5e382f 100644 (file)
@@ -8877,7 +8877,7 @@ get_narrower (tree op, int *unsignedp_ptr)
        v.safe_push (op);
       FOR_EACH_VEC_ELT_REVERSE (v, i, op)
        ret = build2_loc (EXPR_LOCATION (op), COMPOUND_EXPR,
-                         TREE_TYPE (win), TREE_OPERAND (op, 0),
+                         TREE_TYPE (ret), TREE_OPERAND (op, 0),
                          ret);
       return ret;
     }