nvc0/ir: fix TargetNVC0::insnCanLoadOffset()
authorRhys Perry <pendingchaos02@gmail.com>
Thu, 28 Jun 2018 13:26:33 +0000 (14:26 +0100)
committerKarol Herbst <kherbst@redhat.com>
Thu, 28 Jun 2018 16:22:06 +0000 (18:22 +0200)
Previously, TargetNVC0::insnCanLoadOffset() returned whether the offset
could be set to a specific value. The IndirectPropagation pass expected
it to return whether the offset could be increased by a specific value,
which is what TargetNV50::insnCanLoadOffset() does.

Fixes: 37b67db6ae34fb6586d640a7a1b6232f091dd812
("nvc0/ir: be careful about propagating very large offsets into const load")

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Signed-off-by: Karol Herbst <kherbst@redhat.com>
src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp

index 954aec0a2f9770b2c8cd4abdbbd2d12c59444f2e..8938d19f6cf2bc74cea17af6cce8aba46babb19d 100644 (file)
@@ -415,6 +415,7 @@ bool
 TargetNVC0::insnCanLoadOffset(const Instruction *insn, int s, int offset) const
 {
    const ValueRef& ref = insn->src(s);
+   offset += insn->src(s).get()->reg.data.offset;
    if (ref.getFile() == FILE_MEMORY_CONST &&
        (insn->op != OP_LOAD || insn->subOp != NV50_IR_SUBOP_LDC_IS))
       return offset >= -0x8000 && offset < 0x8000;